Bug 167363 - Some complex text with initial advances is misplaced
Summary: Some complex text with initial advances is misplaced
Status: RESOLVED DUPLICATE of bug 166013
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-24 01:26 PST by Myles C. Maxfield
Modified: 2017-01-24 15:53 PST (History)
0 users

See Also:


Attachments
WIP (21.95 KB, patch)
2017-01-24 01:27 PST, Myles C. Maxfield
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2017-01-24 01:26:09 PST
Some complex text with initial advances is misplaced
Comment 1 Myles C. Maxfield 2017-01-24 01:27:05 PST
Created attachment 299585 [details]
WIP
Comment 2 Myles C. Maxfield 2017-01-24 01:32:52 PST

*** This bug has been marked as a duplicate of bug 166013 ***
Comment 3 Myles C. Maxfield 2017-01-24 15:43:19 PST
Comment on attachment 299585 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=299585&action=review

> Source/WebCore/platform/graphics/mac/ComplexTextController.h:94
>          const UChar* characters() const { return m_characters; }

No need for ComplexTextRun to be RefCounted (Probably)
Comment 4 Myles C. Maxfield 2017-01-24 15:53:45 PST
Comment on attachment 299585 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=299585&action=review

> Source/WebCore/platform/graphics/mac/ComplexTextController.h:100
>          CFIndex endOffsetAt(size_t i) const { ASSERT(!m_isMonotonic); return m_glyphEndOffsets[i]; }

m_isMonotonic { true }