RESOLVED FIXED 167339
Cleanup WEB_TIMING code
https://bugs.webkit.org/show_bug.cgi?id=167339
Summary Cleanup WEB_TIMING code
Joseph Pecoraro
Reported 2017-01-23 15:59:25 PST
Just did an audit of the WEB_TIMING code and addressed tiny issues.
Attachments
[PATCH] Proposed Fix (12.82 KB, patch)
2017-01-23 16:02 PST, Joseph Pecoraro
no flags
Joseph Pecoraro
Comment 1 2017-01-23 16:02:45 PST
Created attachment 299550 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 2 2017-01-23 16:06:03 PST
Attachment 299550 [details] did not pass style-queue: ERROR: Source/WebCore/page/PerformanceMeasure.h:42: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/PerformanceMark.h:42: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] Total errors found: 2 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 3 2017-01-23 17:18:08 PST
Comment on attachment 299550 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=299550&action=review > Source/WebCore/loader/SubresourceLoader.cpp:544 > + if (Document* document = m_documentLoader->cachedResourceLoader().document()) auto*
WebKit Commit Bot
Comment 4 2017-01-23 19:14:10 PST
Comment on attachment 299550 [details] [PATCH] Proposed Fix Clearing flags on attachment: 299550 Committed r211074: <http://trac.webkit.org/changeset/211074>
WebKit Commit Bot
Comment 5 2017-01-23 19:14:15 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.