Bug 167315 - JavaScriptCore fails to build on Linux because -lpthread is missing
Summary: JavaScriptCore fails to build on Linux because -lpthread is missing
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-23 11:27 PST by Timothy Hatcher
Modified: 2017-01-23 11:54 PST (History)
1 user (show)

See Also:


Attachments
Patch (1.13 KB, patch)
2017-01-23 11:29 PST, Timothy Hatcher
timothy: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2017-01-23 11:27:47 PST
We need to add find_package(Threads) to Source/cmake/WebKitCommon.cmake to make it link correctly like I needed to do in bug 167313.
Comment 1 Timothy Hatcher 2017-01-23 11:29:45 PST
Created attachment 299528 [details]
Patch
Comment 2 Alex Christensen 2017-01-23 11:48:38 PST
Comment on attachment 299528 [details]
Patch

If this is only needed on Linux, should this be in WebKitCommon?  Are you using the GTK port?
Comment 3 Timothy Hatcher 2017-01-23 11:54:17 PST
I found the error in my end with my Cmake options. This is a different Linux port.