Bug 167314 - Use priorities in speculative revalidation
Summary: Use priorities in speculative revalidation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-01-23 11:11 PST by Antti Koivisto
Modified: 2017-02-01 06:04 PST (History)
5 users (show)

See Also:

Attachments
patch (7.35 KB, patch)
2017-01-23 12:09 PST, Antti Koivisto 		cdumez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2017-01-23 11:11:00 PST 
We currently do all speculative cache operations with 'Medium' priority and network operations with 'Low'. We should use the actual request priorities instead.
Comment 1 Antti Koivisto 2017-01-23 12:09:52 PST 
Created attachment 299530 [details]
patch
Comment 2 Chris Dumez 2017-01-23 12:14:36 PST 
Comment on attachment 299530 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299530&action=review

r=me

> Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:492
> +    

spacing issue.

> Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:536
> +    m_storage.retrieve(subresourcesStorageKey, static_cast<unsigned>(WebCore::ResourceLoadPriority::High), [completionHandler = WTFMove(completionHandler)](auto record) {

Why the extra WebCore:: ? The priority change might be risky as I used that value based on PLT results.
Comment 3 Antti Koivisto 2017-01-23 12:23:27 PST 
https://trac.webkit.org/r211049
Comment 4 Radar WebKit Bug Importer 2017-02-01 06:04:11 PST 
<rdar://problem/30306336>