Bug 167311 - LayoutTest media/modern-media-controls/tracks-panel/tracks-panel-hide.html is a flaky timeout
Summary: LayoutTest media/modern-media-controls/tracks-panel/tracks-panel-hide.html is...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-23 09:28 PST by Ryan Haddad
Modified: 2017-01-24 19:00 PST (History)
2 users (show)

See Also:


Attachments
Patch (3.26 KB, patch)
2017-01-24 14:19 PST, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Ryan Haddad 2017-01-23 13:29:53 PST
This appears to be limited to macOS debug.
Comment 2 Ryan Haddad 2017-01-23 13:32:59 PST
Marked test as flaky in http://trac.webkit.org/projects/webkit/changeset/211059
Comment 3 Antoine Quint 2017-01-24 14:06:34 PST
The timeout is caused by the "transitionend" event not being fired.
Comment 4 Antoine Quint 2017-01-24 14:11:55 PST
This looks like a bug in the TracksPanel class where we register for the "transitionend" event at the same time we apply the "fade-out" class that triggers the transition. But in case the value we're animating from is already 0, we won't have a chance to transition and there will be no event. So we need to register for the event first and delay the transition until the next frame.
Comment 5 Antoine Quint 2017-01-24 14:19:04 PST
Created attachment 299631 [details]
Patch
Comment 6 WebKit Commit Bot 2017-01-24 19:00:28 PST
Comment on attachment 299631 [details]
Patch

Clearing flags on attachment: 299631

Committed r211131: <http://trac.webkit.org/changeset/211131>
Comment 7 WebKit Commit Bot 2017-01-24 19:00:31 PST
All reviewed patches have been landed.  Closing bug.