Bug 167305 - [WebRTC] Add support for WK1 libwebrtc endpoint
Summary: [WebRTC] Add support for WK1 libwebrtc endpoint
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on: 167294
Blocks:
  Show dependency tree / graph
 
Reported: 2017-01-23 07:34 PST by youenn fablet
Modified: 2017-01-25 13:11 PST (History)
2 users (show)

See Also:

Attachments
Patch (7.68 KB, patch)
2017-01-23 08:14 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (4.12 KB, patch)
2017-01-23 17:23 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (4.12 KB, patch)
2017-01-24 09:06 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews116 for mac-elcapitan (1.62 MB, application/zip)
2017-01-24 10:20 PST, Build Bot 		no flags Details
Patch (8.58 KB, patch)
2017-01-25 08:00 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-01-23 07:34:39 PST 
Add support for WK1 libwebrtc endpoint
Comment 1 youenn fablet 2017-01-23 08:14:58 PST 
Created attachment 299516 [details]
Patch
Comment 2 Alex Christensen 2017-01-23 09:56:52 PST 
Comment on attachment 299516 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299516&action=review

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:3758
> +					"$(SRCROOT)/../ThirdParty/libwebrtc/Source",

We need to use forwarding headers.  We can't include ../ because that won't exist on machines doing the internal build.

> Source/WebKit/mac/WebCoreSupport/WebPlatformStrategies.h:40
> +    , private WebCore::RTCStrategy

We are trying to stop using strategies.  Pass an object through the PageConfiguration instead.
Comment 3 youenn fablet 2017-01-23 17:23:17 PST 
Created attachment 299557 [details]
Patch
Comment 4 Alex Christensen 2017-01-23 17:30:45 PST 
Comment on attachment 299557 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299557&action=review

> Source/WebKit/mac/WebView/WebView.mm:1368
> +    pageConfiguration.libWebRTCClient = new WebLibWebRTCClient();

There's no corresponding delete.
I think we should do this more like SocketProvider.  If it doesn't need to be refcounted (which seems like the case because we can't access webrtc from workers for now) then maybe we could just std::unique_ptr or UniqueRef.
Comment 5 youenn fablet 2017-01-24 09:06:01 PST 
Created attachment 299604 [details]
Patch
Comment 6 Build Bot 2017-01-24 10:20:53 PST 
Comment on attachment 299604 [details]
Patch

Attachment 299604 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2941627

New failing tests:
media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen.html
Comment 7 Build Bot 2017-01-24 10:20:55 PST 
Created attachment 299610 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 8 Alex Christensen 2017-01-24 14:43:02 PST 
Comment on attachment 299604 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299604&action=review

> Source/WebKit/mac/WebCoreSupport/WebLibWebRTCClient.h:34
> +class WebLibWebRTCClient final : public WebCore::LibWebRTCClient {

LibWebRTCProvider
Comment 9 youenn fablet 2017-01-25 08:00:34 PST 
Created attachment 299705 [details]
Patch
Comment 10 youenn fablet 2017-01-25 13:11:16 PST 
Solved as part of bug 167294