WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
167303
[JSC] Optimize Number#toString with Int52
https://bugs.webkit.org/show_bug.cgi?id=167303
Summary
[JSC] Optimize Number#toString with Int52
Yusuke Suzuki
Reported
2017-01-23 06:06:56 PST
Currently, Int52 cases are just handled in double context. We should have a fast path for that since it is frequently called in kraken crypto.
Attachments
Patch
(6.86 KB, patch)
2017-01-23 06:29 PST
,
Yusuke Suzuki
no flags
Details
Formatted Diff
Diff
Patch
(9.84 KB, patch)
2017-01-24 03:43 PST
,
Yusuke Suzuki
sam
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1
2017-01-23 06:07:54 PST
First, I'll implement this optimization in runtime function, it should offer perf boost for all the tiers. After that, I'll investigate DFG / FTL Number#toString handling.
Yusuke Suzuki
Comment 2
2017-01-23 06:29:14 PST
Created
attachment 299513
[details]
Patch
Yusuke Suzuki
Comment 3
2017-01-24 03:43:45 PST
Created
attachment 299595
[details]
Patch
Yusuke Suzuki
Comment 4
2017-01-24 18:42:12 PST
Committed
r211128
: <
http://trac.webkit.org/changeset/211128
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug