Bug 167303 - [JSC] Optimize Number#toString with Int52
Summary: [JSC] Optimize Number#toString with Int52
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-23 06:06 PST by Yusuke Suzuki
Modified: 2017-01-24 18:42 PST (History)
5 users (show)

See Also:

Attachments
Patch (6.86 KB, patch)
2017-01-23 06:29 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (9.84 KB, patch)
2017-01-24 03:43 PST, Yusuke Suzuki 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-01-23 06:06:56 PST 
Currently, Int52 cases are just handled in double context.
We should have a fast path for that since it is frequently called in kraken crypto.
Comment 1 Yusuke Suzuki 2017-01-23 06:07:54 PST 
First, I'll implement this optimization in runtime function, it should offer perf boost for all the tiers.
After that, I'll investigate DFG / FTL Number#toString handling.
Comment 2 Yusuke Suzuki 2017-01-23 06:29:14 PST 
Created attachment 299513 [details]
Patch
Comment 3 Yusuke Suzuki 2017-01-24 03:43:45 PST 
Created attachment 299595 [details]
Patch
Comment 4 Yusuke Suzuki 2017-01-24 18:42:12 PST 
Committed r211128: <http://trac.webkit.org/changeset/211128>