Bug 167302 - [SOUP] DNS prefetch is always done in the default session
Summary: [SOUP] DNS prefetch is always done in the default session
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Soup
Depends on:
Blocks:
 
Reported: 2017-01-23 02:43 PST by Carlos Garcia Campos
Modified: 2017-01-23 07:13 PST (History)
9 users (show)

See Also:

Attachments
Patch (21.46 KB, patch)
2017-01-23 02:58 PST, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-01-23 02:43:55 PST 
DNS::prefetchDNS() should receive a SessionID.
Comment 1 Carlos Garcia Campos 2017-01-23 02:58:01 PST 
Created attachment 299510 [details]
Patch
Comment 2 WebKit Commit Bot 2017-01-23 03:00:20 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Sergio Villar Senin 2017-01-23 06:42:35 PST 
Comment on attachment 299510 [details]
Patch

Not sure we want to enable dns prefetch for private sessions for example. It might be a way to fingerprint users, something that goes against the purpose of private sessions.
Comment 4 Michael Catanzaro 2017-01-23 06:48:02 PST 
Yes, we should not prefetch at all in ephemeral sessions.
Comment 5 Carlos Garcia Campos 2017-01-23 07:06:51 PST 
Godd point, then we should still receive the session id to check if it's ephemeral and do nothing, there's no point of prefetch on the default session when in private session, no?
Comment 6 Michael Catanzaro 2017-01-23 07:11:32 PST 
(In reply to comment #5)
> there's no point of prefetch on the default
> session when in private session, no?

The point is to not leak hosts that have not even been visited via DNS. So yes, I would not do it at all.
Comment 7 Michael Catanzaro 2017-01-23 07:12:16 PST 
(I don't think the session the prefetch occurs in matters at all, by the way, since the DNS cache is system-wide.)
Comment 8 Carlos Garcia Campos 2017-01-23 07:13:41 PST 
(In reply to comment #7)
> (I don't think the session the prefetch occurs in matters at all, by the
> way, since the DNS cache is system-wide.)

Ah! I thought it was per session.