Bug 167302 – [SOUP] DNS prefetch is always done in the default session

• Status: NEW
• Component: Platform

[Carlos Garcia Campos]

DNS::prefetchDNS() should receive a SessionID.

[Carlos Garcia Campos]

Created attachment 299510 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Sergio Villar Senin]

Comment on attachment 299510 [details]
Patch

Not sure we want to enable dns prefetch for private sessions for example. It might be a way to fingerprint users, something that goes against the purpose of private sessions.

[Michael Catanzaro]

Yes, we should not prefetch at all in ephemeral sessions.

[Carlos Garcia Campos]

Godd point, then we should still receive the session id to check if it's ephemeral and do nothing, there's no point of prefetch on the default session when in private session, no?

[Michael Catanzaro]

(In reply to comment #5)
> there's no point of prefetch on the default
> session when in private session, no?

The point is to not leak hosts that have not even been visited via DNS. So yes, I would not do it at all.

[Michael Catanzaro]

(I don't think the session the prefetch occurs in matters at all, by the way, since the DNS cache is system-wide.)

[Carlos Garcia Campos]

(In reply to comment #7)
> (I don't think the session the prefetch occurs in matters at all, by the
> way, since the DNS cache is system-wide.)

Ah! I thought it was per session.