Bug 167292 – [Xcode] Clean up PAL and WebCore’s build settings a little

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

Patch forthcoming.

Created attachment 299470 [details]
Tidy things up a bit

[Myles C. Maxfield]

Comment on attachment 299470 [details]
Tidy things up a bit

View in context: https://bugs.webkit.org/attachment.cgi?id=299470&action=review

> Source/WebCore/ChangeLog:22
> +        * PAL/Configurations/Base.xcconfig: Simplified the definition of
> +          GCC_WARN_64_TO_32_BIT_CONVERSION, removed the unused build setting PREBINDING, removed
> +          a duplicate definition of GCC_GENERATE_DEBUGGING_SYMBOLS, and removed definitions specific
> +          to OS X versions that are no longer supported.
> +
> +        * PAL/Configurations/DebugRelease.xcconfig: Removed definitions specific to OS X versions
> +          that are no longer supported.
> +
> +        * PAL/Configurations/PAL.xcconfig: Removed header search paths that do not exist or do not
> +          make sense. Simplified the definitions of INSTALL_PATH and SKIP_INSTALL. Removed the
> +          unusued build settings PRODUCT_BUNDLE_IDENTIFIER and
> +          WK_PREFIXED_IPHONEOS_DEPLOYMENT_TARGET. Removed the redundant definition of
> +          EXECUTABLE_PREFIX.
> +
> +        * PAL/PAL.xcodeproj/project.pbxproj: Sorted the Configurations group.

Shouldn't this stuff also be done in WebCore too?

[Alex Christensen]

If we intend to eventually move PAL to its own subdirectory of Source, shouldn't we add a ChangeLog sooner rather than later to have a more complete change history when we move it?

(In reply to comment #3)
> If we intend to eventually move PAL to its own subdirectory of Source,
> shouldn't we add a ChangeLog sooner rather than later to have a more
> complete change history when we move it?

Yes. Not sure how your question relates to this bug :)

[Alex Christensen]

This bug makes changes to PAL and has a ChangeLog entry...in WebCore

Created attachment 300035 [details]
Tidy up

Committed <https://trac.webkit.org/r211338>.