Bug 167279 – Convert langAttributeAwareFormControlUIEnabled to a Setting

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Joseph Pecoraro]

Convert langAttributeAwareFormControlUIEnabled to a Setting.

- This doesn't fit the normal qualifications for a RuntimeEnabledFeature.
- It can be an autogenerated Setting.

[Joseph Pecoraro]

Created attachment 299424 [details]
[PATCH] Proposed Fix

[Darin Adler]

Comment on attachment 299424 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=299424&action=review

> Source/WebCore/html/HTMLInputElement.cpp:2038
> +    Settings* settings = document.settings();

Needs to be document() rather than document.

[Joseph Pecoraro]

Comment on attachment 299424 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=299424&action=review

>> Source/WebCore/html/HTMLInputElement.cpp:2038
>> +    Settings* settings = document.settings();
> 
> Needs to be document() rather than document.

Wow, thats embarrassing =O

[Joseph Pecoraro]

Created attachment 299502 [details]
[PATCH] Proposed Fix

[Sam Weinig]

Comment on attachment 299502 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=299502&action=review

Very nice! I long to see the death of RuntimeEnabledFeatures! Perhaps it deserves a rename to DeprecatedRuntimeEnabledFeatures as per our custom.

> Source/WebCore/html/HTMLInputElement.cpp:2039
> +    Settings* settings = document().settings();
> +    if (!settings || !settings->langAttributeAwareFormControlUIEnabled())

It might be time to consider giving Document a Settings Ref<>.

[WebKit Commit Bot]

Comment on attachment 299502 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 299502

Committed r211055: <http://trac.webkit.org/changeset/211055>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.