Bug 167258 - [ios-simulator] Unskip media/modern-media-controls/audio/audio-controls-metrics.html
Summary: [ios-simulator] Unskip media/modern-media-controls/audio/audio-controls-metri...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-01-20 14:46 PST by Ryan Haddad
Modified: 2017-03-01 15:09 PST (History)
3 users (show)

See Also:


Attachments
Patch (3.01 KB, patch)
2017-03-01 14:36 PST, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (2.98 KB, patch)
2017-03-01 14:40 PST, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2017-01-20 14:46:34 PST
[ios-simulator] LayoutTest media/modern-media-controls/audio/audio-controls-metrics.html is failing

https://build.webkit.org/results/Apple%20iOS%2010%20Simulator%20Release%20WK2%20(Tests)/r210980%20(3041)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Faudio%2Faudio-controls-metrics.html

--- /Volumes/Data/slave/ios-simulator-10-release-tests-wk2/build/layout-test-results/media/modern-media-controls/audio/audio-controls-metrics-expected.txt
+++ /Volumes/Data/slave/ios-simulator-10-release-tests-wk2/build/layout-test-results/media/modern-media-controls/audio/audio-controls-metrics-actual.txt
@@ -3,7 +3,7 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS bounds.width is 200
+FAIL bounds.width should be 200. Was 260.
 PASS bounds.height is 50
 
 PASS successfullyParsed is true
Comment 1 Ryan Haddad 2017-01-20 14:50:13 PST
Marked as failing on ios-simulator-wk2 in http://trac.webkit.org/projects/webkit/changeset/210989
Comment 2 Radar WebKit Bug Importer 2017-01-31 02:38:50 PST
<rdar://problem/30282740>
Comment 3 Antoine Quint 2017-01-31 02:46:59 PST
Skipped in https://trac.webkit.org/changeset/211418.
Comment 4 Antoine Quint 2017-03-01 14:36:07 PST
Created attachment 303120 [details]
Patch
Comment 5 WebKit Commit Bot 2017-03-01 14:37:18 PST
Attachment 303120 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:13:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Antoine Quint 2017-03-01 14:40:25 PST
Created attachment 303121 [details]
Patch
Comment 7 WebKit Commit Bot 2017-03-01 15:09:34 PST
Comment on attachment 303121 [details]
Patch

Clearing flags on attachment: 303121

Committed r213250: <http://trac.webkit.org/changeset/213250>
Comment 8 WebKit Commit Bot 2017-03-01 15:09:37 PST
All reviewed patches have been landed.  Closing bug.