Bug 167257 - [WebRTC] Make VP8 optional in libwebrtc
Summary: [WebRTC] Make VP8 optional in libwebrtc
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-20 14:35 PST by youenn fablet
Modified: 2018-01-03 09:20 PST (History)
3 users (show)

See Also:

Attachments
Patch (10.60 KB, patch)
2017-01-20 14:40 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-01-20 14:35:35 PST 
[WebRTC] Make VP8 optional in libwebrtc
Comment 1 youenn fablet 2017-01-20 14:40:01 PST 
Created attachment 299389 [details]
Patch
Comment 2 WebKit Commit Bot 2017-01-20 14:41:14 PST 
Attachment 299389 [details] did not pass style-queue:


ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp8/include/vp8.h:22:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp8/include/vp8.h:30:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2017-01-23 11:33:53 PST 
Comment on attachment 299389 [details]
Patch

Clearing flags on attachment: 299389

Committed r211046: <http://trac.webkit.org/changeset/211046>
Comment 4 WebKit Commit Bot 2017-01-23 11:33:57 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Anton Venema 2018-01-03 09:20:37 PST 
Since VP8 is a MTI video codec for WebRTC, what reason is there to make it optional in libwebrtc?