[WebRTC] Update build system to make G711 optional in libwebrtc
Created attachment 299386 [details] Patch
Attachment 299386 [details] did not pass style-queue: ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp8/include/vp8.h:22: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp8/include/vp8.h:30: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 299390 [details] Patch
Comment on attachment 299390 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299390&action=review This patch looks like we are adding support for g711. It shouldn't. > Source/ThirdParty/libwebrtc/CMakeLists.txt:128 > +set_target_properties(WebrtcModulesAudio_CodingG711 PROPERTIES LINK_FLAGS "-stdlib=libc++ -arch x86_64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -mmacosx-version-min=10.9") shouldn't hard-code path.
Created attachment 299415 [details] Patch
Comment on attachment 299415 [details] Patch Clearing flags on attachment: 299415 Committed r211009: <http://trac.webkit.org/changeset/211009>
All reviewed patches have been landed. Closing bug.
The title is ambiguous, G711 is Mandatory to Implement in WebRTC, are you planning NOT to support it, or are you just planning to support it a different way than the one libwebrtc is?
(In reply to comment #8) > The title is ambiguous, G711 is Mandatory to Implement in WebRTC, are you > planning NOT to support it, or are you just planning to support it a > different way than the one libwebrtc is? It would be nice to support it. The direction is still unclear though.
OK. 1. It's impossible to be compliant with the IETF specs without it. 2. A lot of mobile solutions/SDKs shy away from Opus because of resource constraints and fall back to G711 for webRTC compliance / interoperability. Let's wait and see what the direction will be ;-)