Bug 167256 - [WebRTC] Update build system to make G711 optional in libwebrtc
Summary: [WebRTC] Update build system to make G711 optional in libwebrtc
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-20 14:18 PST by youenn fablet
Modified: 2017-01-20 21:11 PST (History)
3 users (show)

See Also:

Attachments
Patch (46.07 KB, patch)
2017-01-20 14:34 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (37.85 KB, patch)
2017-01-20 14:41 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (5.28 KB, patch)
2017-01-20 18:01 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-01-20 14:18:26 PST 
[WebRTC] Update build system to make G711 optional in libwebrtc
Comment 1 youenn fablet 2017-01-20 14:34:13 PST 
Created attachment 299386 [details]
Patch
Comment 2 WebKit Commit Bot 2017-01-20 14:37:32 PST 
Attachment 299386 [details] did not pass style-queue:


ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp8/include/vp8.h:22:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp8/include/vp8.h:30:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 youenn fablet 2017-01-20 14:41:06 PST 
Created attachment 299390 [details]
Patch
Comment 4 Alex Christensen 2017-01-20 17:45:42 PST 
Comment on attachment 299390 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299390&action=review

This patch looks like we are adding support for g711.  It shouldn't.

> Source/ThirdParty/libwebrtc/CMakeLists.txt:128
> +set_target_properties(WebrtcModulesAudio_CodingG711 PROPERTIES LINK_FLAGS "-stdlib=libc++ -arch x86_64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -mmacosx-version-min=10.9")

shouldn't hard-code path.
Comment 5 youenn fablet 2017-01-20 18:01:59 PST 
Created attachment 299415 [details]
Patch
Comment 6 WebKit Commit Bot 2017-01-20 18:37:16 PST 
Comment on attachment 299415 [details]
Patch

Clearing flags on attachment: 299415

Committed r211009: <http://trac.webkit.org/changeset/211009>
Comment 7 WebKit Commit Bot 2017-01-20 18:37:20 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Alex. Gouaillard 2017-01-20 19:12:25 PST 
The title is ambiguous, G711 is Mandatory to Implement in WebRTC, are  you planning NOT to support it, or are you just planning to support it a different way than the one libwebrtc is?
Comment 9 youenn fablet 2017-01-20 20:54:52 PST 
(In reply to comment #8)
> The title is ambiguous, G711 is Mandatory to Implement in WebRTC, are  you
> planning NOT to support it, or are you just planning to support it a
> different way than the one libwebrtc is?

It would be nice to support it. The direction is still unclear though.
Comment 10 Alex. Gouaillard 2017-01-20 21:11:30 PST 
OK.
1. It's impossible to be compliant with the IETF specs without it.
2. A lot of mobile solutions/SDKs shy away from Opus because of resource constraints and fall back to G711 for webRTC compliance / interoperability.
Let's wait and see what the direction will be ;-)