Bug 167253 - LayoutTest media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html is flaky
Summary: LayoutTest media/modern-media-controls/macos-fullscreen-media-controls/macos-...
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
Depends on:
Reported: 2017-01-20 13:48 PST by Ryan Haddad
Modified: 2017-01-25 10:33 PST (History)
2 users (show)

See Also:

Patch (3.98 KB, patch)
2017-01-25 05:11 PST, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2017-01-20 13:48:20 PST
LayoutTest media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html is flaky 



--- /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles-expected.txt
+++ /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles-actual.txt
@@ -3,14 +3,14 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS centerContainerBounds.left is 311
+FAIL centerContainerBounds.left should be 311. Was 346.
 PASS centerContainerBounds.top is 500
-PASS centerContainerBounds.width is 178
+FAIL centerContainerBounds.width should be 178. Was 108.
 PASS centerContainerBounds.height is 44
-PASS rightContainerBounds.left is within 0.5 of 493
+FAIL rightContainerBounds.left should be within 0.5 of 493. Was 562.
 PASS rightContainerBounds.top is 500
-PASS rightContainerBounds.width is within 0.5 of 141
+FAIL rightContainerBounds.width should be within 0.5 of 141. Was 72.
 PASS rightContainerBounds.height is 44
 PASS successfullyParsed is true
Comment 1 Ryan Haddad 2017-01-20 14:09:30 PST
Marked as flaky in http://trac.webkit.org/projects/webkit/changeset/210984
Comment 2 Antoine Quint 2017-01-25 02:00:20 PST
I can get this test to fail fairly reliably with repeated runs and a dedicated instance: Tools/Scripts/run-webkit-tests --debug -1 -g --no-retry --no-sample-on-timeout --time-out-ms=10000 --run-singly --iterations=100 --exit-after-n-failures=1 media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html
Comment 3 Antoine Quint 2017-01-25 05:05:19 PST
The problem is a source issue with IconButton where we don't notify the layout delegate when the image metrics has changed, so we can get in situations where the layout of the buttons container is incorrect, based on 0-width buttons. The test itself is correct.
Comment 4 Antoine Quint 2017-01-25 05:11:08 PST
Created attachment 299692 [details]
Comment 5 WebKit Commit Bot 2017-01-25 10:33:23 PST
Comment on attachment 299692 [details]

Clearing flags on attachment: 299692

Committed r211154: <http://trac.webkit.org/changeset/211154>
Comment 6 WebKit Commit Bot 2017-01-25 10:33:26 PST
All reviewed patches have been landed.  Closing bug.