Bug 167252 - Remove outdated ENABLE(CSP_NEXT) build flag
Summary: Remove outdated ENABLE(CSP_NEXT) build flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-20 13:32 PST by Joseph Pecoraro
Modified: 2017-01-20 15:25 PST (History)
4 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (60.56 KB, patch)
2017-01-20 13:33 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-01-20 13:32:41 PST 
Remove outdated ENABLE(CSP_NEXT) build flag

- This is for CSP 1.1, but we implement CSP 2
- It only guards document.onsecuritypolicyviolation which has been removed in more recent versions of CSP
- It only enabled by what looks like Windows ports
Comment 1 Joseph Pecoraro 2017-01-20 13:33:58 PST 
Created attachment 299377 [details]
[PATCH] Proposed Fix
Comment 2 Brent Fulgham 2017-01-20 14:57:59 PST 
Comment on attachment 299377 [details]
[PATCH] Proposed Fix

Yes, please get rid of it! This is a bit of forgotten code that we didn't remove during the CSP work last year. Thanks for catching this.
Comment 3 WebKit Commit Bot 2017-01-20 15:25:10 PST 
Comment on attachment 299377 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 299377

Committed r210992: <http://trac.webkit.org/changeset/210992>
Comment 4 WebKit Commit Bot 2017-01-20 15:25:14 PST 
All reviewed patches have been landed.  Closing bug.