Bug 167249 - Land the stochastic space-time scheduler disabled
Summary: Land the stochastic space-time scheduler disabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks: 167248
  Show dependency treegraph
 
Reported: 2017-01-20 12:56 PST by Filip Pizlo
Modified: 2017-01-24 13:58 PST (History)
2 users (show)

See Also:


Attachments
the patch (28.68 KB, patch)
2017-01-20 13:06 PST, Filip Pizlo
no flags Details | Formatted Diff | Diff
more (36.42 KB, patch)
2017-01-21 11:17 PST, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (38.90 KB, patch)
2017-01-22 19:23 PST, Filip Pizlo
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2017-01-20 12:56:40 PST
Patch forthcoming.
Comment 1 Filip Pizlo 2017-01-20 13:06:53 PST
Created attachment 299370 [details]
the patch
Comment 2 WebKit Commit Bot 2017-01-20 13:08:47 PST
Attachment 299370 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/heap/StochasticSpaceTimeMutatorScheduler.cpp:106:  Declaration has space between type name and * in constraintExecutionDuration * m_pauseScale  [whitespace/declaration] [3]
ERROR: Source/JavaScriptCore/heap/Heap.cpp:58:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2017-01-21 11:17:57 PST
Created attachment 299436 [details]
more

Having tuned it I'm seeing some wins but now I need to verify that I didn't break perf of the old scheduler.

I sorta want to land with the new scheduler disabled because I had to make other changes and I want to make sure that those changes don't mess anything up.
Comment 4 Filip Pizlo 2017-01-22 19:23:03 PST
Created attachment 299491 [details]
the patch
Comment 5 WebKit Commit Bot 2017-01-22 19:25:43 PST
Attachment 299491 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/heap/StochasticSpaceTimeMutatorScheduler.cpp:106:  Declaration has space between type name and * in constraintExecutionDuration * m_pauseScale  [whitespace/declaration] [3]
ERROR: Source/JavaScriptCore/heap/Heap.cpp:58:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Saam Barati 2017-01-23 15:43:47 PST
Comment on attachment 299491 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299491&action=review

r=me

> Source/JavaScriptCore/heap/StochasticSpaceTimeMutatorScheduler.cpp:2
> + * Copyright (C) 2016-2017 Apple Inc. All rights reserved.

2017

> Source/JavaScriptCore/heap/StochasticSpaceTimeMutatorScheduler.h:2
> + * Copyright (C) 2016-2017 Apple Inc. All rights reserved.

2017
Comment 7 Filip Pizlo 2017-01-23 16:02:43 PST
Landed in https://trac.webkit.org/changeset/211069
Comment 8 Radar WebKit Bug Importer 2017-01-24 13:58:49 PST
<rdar://problem/30173274>