Bug 167245 - [WebRTC] libwebrtc H.264 codec is using VTB only for IOS
Summary: [WebRTC] libwebrtc H.264 codec is using VTB only for IOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-20 11:03 PST by youenn fablet
Modified: 2017-01-23 19:21 PST (History)
3 users (show)

See Also:

Attachments
Patch (4.18 KB, patch)
2017-01-20 11:04 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-01-20 11:03:09 PST 
It could also be activated for MAC as well.
Comment 1 youenn fablet 2017-01-20 11:04:15 PST 
Created attachment 299358 [details]
Patch
Comment 2 Alex Christensen 2017-01-20 11:06:41 PST 
Comment on attachment 299358 [details]
Patch

I assume since this is in the objc subdirectory this won't be used on linux and windows, right?
Comment 3 youenn fablet 2017-01-20 11:18:40 PST 
(In reply to comment #2)
> Comment on attachment 299358 [details]
> Patch
> 
> I assume since this is in the objc subdirectory this won't be used on linux
> and windows, right?

Right, BUILD.gn is including this file and directory only for Mac and iOS targets
Comment 4 WebKit Commit Bot 2017-01-20 11:43:08 PST 
Comment on attachment 299358 [details]
Patch

Clearing flags on attachment: 299358

Committed r210974: <http://trac.webkit.org/changeset/210974>
Comment 5 WebKit Commit Bot 2017-01-20 11:43:13 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Alex. Gouaillard 2017-01-21 16:26:10 PST 
Not supposing anything about other reasons one would have not to enable this on Mac, 

what was the first version of MacOS X to support VTB (so we could guard against earlier version in the GN script)?
Comment 7 youenn fablet 2017-01-21 18:06:22 PST 
(In reply to comment #6)
> Not supposing anything about other reasons one would have not to enable this
> on Mac, 
> 
> what was the first version of MacOS X to support VTB (so we could guard
> against earlier version in the GN script)?

Good point, I'll check that.
Comment 8 Alex. Gouaillard 2017-01-23 19:21:03 PST 
I saw info saying it should be iOS 8 and MacOSX 10.8?