RESOLVED FIXED 167245
[WebRTC] libwebrtc H.264 codec is using VTB only for IOS 
https://bugs.webkit.org/show_bug.cgi?id=167245
Summary [WebRTC] libwebrtc H.264 codec is using VTB only for IOS
youenn fablet
Reported 2017-01-20 11:03:09 PST
It could also be activated for MAC as well.
Attachments
Patch (4.18 KB, patch)
2017-01-20 11:04 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-01-20 11:04:15 PST
Created attachment 299358 [details] Patch
Alex Christensen
Comment 2 2017-01-20 11:06:41 PST
Comment on attachment 299358 [details] Patch I assume since this is in the objc subdirectory this won't be used on linux and windows, right?
youenn fablet
Comment 3 2017-01-20 11:18:40 PST
(In reply to comment #2) > Comment on attachment 299358 [details] > Patch > > I assume since this is in the objc subdirectory this won't be used on linux > and windows, right? Right, BUILD.gn is including this file and directory only for Mac and iOS targets
WebKit Commit Bot
Comment 4 2017-01-20 11:43:08 PST
Comment on attachment 299358 [details] Patch Clearing flags on attachment: 299358 Committed r210974: <http://trac.webkit.org/changeset/210974>
WebKit Commit Bot
Comment 5 2017-01-20 11:43:13 PST
All reviewed patches have been landed. Closing bug.
Alex. Gouaillard
Comment 6 2017-01-21 16:26:10 PST
Not supposing anything about other reasons one would have not to enable this on Mac, what was the first version of MacOS X to support VTB (so we could guard against earlier version in the GN script)?
youenn fablet
Comment 7 2017-01-21 18:06:22 PST
(In reply to comment #6) > Not supposing anything about other reasons one would have not to enable this > on Mac, > > what was the first version of MacOS X to support VTB (so we could guard > against earlier version in the GN script)? Good point, I'll check that.
Alex. Gouaillard
Comment 8 2017-01-23 19:21:03 PST
I saw info saying it should be iOS 8 and MacOSX 10.8?
Note You need to log in before you can comment on or make changes to this bug.