Video details does not apear and missing scrubber in Control Center
Created attachment 299353 [details] Patch
rdar://problem/29486368
Created attachment 299372 [details] Patch
Created attachment 299373 [details] Patch
Created attachment 299375 [details] Patch
Comment on attachment 299375 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299375&action=review > Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.h:73 > + bool hasActiveNowPlayingSession() const override { return m_nowPlayingActive; } final? > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:318 > +- (void)_requestActiveNowPlayingSessionInfo WK_API_AVAILABLE(macosx(WK_MAC_TBA)); > +- (void)_handleActiveNowPlayingSessionInfoResponse:(BOOL)hasActiveSession title:(NSString *)title duration:(double)duration elapsedTime:(double)elapsedTime WK_API_AVAILABLE(macosx(WK_MAC_TBA)); These need a , ios(WK_IOS_TBA) I think this should have a completionHandler for when you get your result instead of making subclasses override a selector. That's an awful API design.
(In reply to comment #6) > Comment on attachment 299375 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=299375&action=review > > > Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.h:73 > > + bool hasActiveNowPlayingSession() const override { return m_nowPlayingActive; } > > final? Ok. > > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:318 > > +- (void)_requestActiveNowPlayingSessionInfo WK_API_AVAILABLE(macosx(WK_MAC_TBA)); > > +- (void)_handleActiveNowPlayingSessionInfoResponse:(BOOL)hasActiveSession title:(NSString *)title duration:(double)duration elapsedTime:(double)elapsedTime WK_API_AVAILABLE(macosx(WK_MAC_TBA)); > > These need a , ios(WK_IOS_TBA) Ok. > I think this should have a completionHandler for when you get your result > instead of making subclasses override a selector. That's an awful API > design. Indeed. I'll file a follow-up.
Created attachment 299519 [details] Patch for landing
Comment on attachment 299519 [details] Patch for landing Clearing flags on attachment: 299519 Committed r211045: <http://trac.webkit.org/changeset/211045>