Bug 167228 – Cleanup RuntimeEnabledFeatures

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Joseph Pecoraro]

Cleanup RuntimeEnabledFeatures

  - Remove unused features
  - Initialize all members
  - Move things around a bit to make it more readable
  - Document features that never change or are not used but have APIs

[Joseph Pecoraro]

Created attachment 299308 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Comment on attachment 299308 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=299308&action=review

> Source/WebCore/page/RuntimeEnabledFeatures.cpp:113
> +#if ENABLE(FETCH_API)
> +    m_isFetchAPIEnabled = false;
> +#endif

Tests are failing because I'm setting the value here. Previously reset() was never setting this.

For all ports that enable the Fetch API this feature is on. (All but WinCairo?)

So I'm going to change this to `true` and see how things go. That better matches the expectations of all ports right now.

[Joseph Pecoraro]

Created attachment 299311 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Comment on attachment 299311 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=299311&action=review

> Source/WebCore/page/RuntimeEnabledFeatures.cpp:116
> +#if ENABLE(DOWNLOAD_ATTRIBUTE)
> +    m_isDownloadAttributeEnabled = false;
> +#endif

Different story here. This is enabled by WebKit2, disabled by WebKit1. reset() previous was not resetting this value. I'll have to do something custom here.

[Joseph Pecoraro]

Created attachment 299316 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Comment on attachment 299316 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=299316&action=review

> Source/WebCore/page/RuntimeEnabledFeatures.cpp:49
>  void RuntimeEnabledFeatures::reset()

This is impossible to make the tests happy when reset is just wrong. I'll remove it battle the failures after removing it (which should be less then battling the failures with it...)

[Build Bot]

Comment on attachment 299316 [details]
[PATCH] Proposed Fix

Attachment 299316 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2918659

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 299321 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 299316 [details]
[PATCH] Proposed Fix

Attachment 299316 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2918709

New failing tests:
webgl/webgl2-rendering-context-obtain.html

[Build Bot]

Created attachment 299322 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 299316 [details]
[PATCH] Proposed Fix

Attachment 299316 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2918741

New failing tests:
webgl/webgl2-rendering-context-obtain.html

[Build Bot]

Created attachment 299325 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Joseph Pecoraro]

Created attachment 299367 [details]
[PATCH] Proposed Fix

I feel pretty good about this one.

[Joseph Pecoraro]

Created attachment 299371 [details]
[PATCH] Proposed Fix

Updated a few tests to new internals APIs.
Updated DRT to better match WTR for experimental features.

[Joseph Pecoraro]

Created attachment 299378 [details]
[PATCH] Proposed Fix

Fixed 1 other test misuse of internals.

[Build Bot]

Comment on attachment 299371 [details]
[PATCH] Proposed Fix

Attachment 299371 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2921924

New failing tests:
fast/dom/navigator-detached-no-crash.html
http/tests/security/cached-cross-origin-preloaded-css-stylesheet.html

[Build Bot]

Created attachment 299380 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 299371 [details]
[PATCH] Proposed Fix

Attachment 299371 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2921989

New failing tests:
http/tests/security/cached-cross-origin-preloaded-css-stylesheet.html

[Build Bot]

Created attachment 299383 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 299371 [details]
[PATCH] Proposed Fix

Attachment 299371 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2921980

New failing tests:
fast/dom/navigator-detached-no-crash.html
http/tests/security/cached-cross-origin-preloaded-css-stylesheet.html

[Build Bot]

Created attachment 299384 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 299371 [details]
[PATCH] Proposed Fix

Attachment 299371 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2922003

New failing tests:
http/tests/security/cached-cross-origin-preloaded-css-stylesheet.html

[Build Bot]

Created attachment 299387 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 299378 [details]
[PATCH] Proposed Fix

Attachment 299378 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2922094

New failing tests:
fast/dom/navigator-detached-no-crash.html

[Build Bot]

Created attachment 299391 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 299378 [details]
[PATCH] Proposed Fix

Attachment 299378 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2922158

New failing tests:
fast/dom/navigator-detached-no-crash.html

[Build Bot]

Created attachment 299393 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Joseph Pecoraro]

Created attachment 299399 [details]
[PATCH] For Bots

[Joseph Pecoraro]

Bots are green!

[Joseph Pecoraro]

<https://trac.webkit.org/changeset/211006>

[Alexey Proskuryakov]

Looks like this broke js/dom/global-constructors-attributes.html on Sierra WK1:

https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r211025%20(3005)/js/dom/global-constructors-attributes-diff.txt

[Joseph Pecoraro]

(In reply to comment #31)
> Looks like this broke js/dom/global-constructors-attributes.html on Sierra
> WK1:
> 
> https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/
> r211025%20(3005)/js/dom/global-constructors-attributes-diff.txt

Thanks for bringing this to my attention. I'll rebaseline. I think this is a progression, we are enabling experimental features in layout tests. If you think this is incorrect for WebKit1 let me know and I can modify our approach.

[Joseph Pecoraro]

> I'll rebaseline.

<https://trac.webkit.org/changeset/211032>

[Joseph Pecoraro]

*** Bug 167185 has been marked as a duplicate of this bug. ***