Bug 167228 - Cleanup RuntimeEnabledFeatures
Summary: Cleanup RuntimeEnabledFeatures
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
: 167185 (view as bug list)
Depends on:
Blocks: 167185
  Show dependency tree / graph
 
Reported: 2017-01-19 20:28 PST by Joseph Pecoraro
Modified: 2017-02-09 16:25 PST (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (36.48 KB, patch)
2017-01-19 20:33 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (36.68 KB, patch)
2017-01-19 21:03 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (36.83 KB, patch)
2017-01-19 21:59 PST, Joseph Pecoraro 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (466.01 KB, application/zip)
2017-01-19 22:54 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews102 for mac-elcapitan (823.55 KB, application/zip)
2017-01-19 23:09 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews116 for mac-elcapitan (1.63 MB, application/zip)
2017-01-19 23:27 PST, Build Bot 		no flags Details
[PATCH] Proposed Fix (84.01 KB, patch)
2017-01-20 12:16 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (93.90 KB, patch)
2017-01-20 13:09 PST, Joseph Pecoraro 		simon.fraser: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
[PATCH] Proposed Fix (94.52 KB, patch)
2017-01-20 13:45 PST, Joseph Pecoraro 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-elcapitan (866.74 KB, application/zip)
2017-01-20 14:09 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (885.36 KB, application/zip)
2017-01-20 14:25 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews113 for mac-elcapitan (1.64 MB, application/zip)
2017-01-20 14:29 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (15.30 MB, application/zip)
2017-01-20 14:37 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews116 for mac-elcapitan (1.71 MB, application/zip)
2017-01-20 14:58 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews102 for mac-elcapitan (897.27 KB, application/zip)
2017-01-20 15:07 PST, Build Bot 		no flags Details
[PATCH] For Bots (95.19 KB, patch)
2017-01-20 15:55 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (14) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-01-19 20:28:50 PST 
Cleanup RuntimeEnabledFeatures

  - Remove unused features
  - Initialize all members
  - Move things around a bit to make it more readable
  - Document features that never change or are not used but have APIs
Comment 1 Joseph Pecoraro 2017-01-19 20:33:03 PST 
Created attachment 299308 [details]
[PATCH] Proposed Fix
Comment 2 Joseph Pecoraro 2017-01-19 20:59:24 PST 
Comment on attachment 299308 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=299308&action=review

> Source/WebCore/page/RuntimeEnabledFeatures.cpp:113
> +#if ENABLE(FETCH_API)
> +    m_isFetchAPIEnabled = false;
> +#endif

Tests are failing because I'm setting the value here. Previously reset() was never setting this.

For all ports that enable the Fetch API this feature is on. (All but WinCairo?)

So I'm going to change this to `true` and see how things go. That better matches the expectations of all ports right now.
Comment 3 Joseph Pecoraro 2017-01-19 21:03:30 PST 
Created attachment 299311 [details]
[PATCH] Proposed Fix
Comment 4 Joseph Pecoraro 2017-01-19 21:53:45 PST 
Comment on attachment 299311 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=299311&action=review

> Source/WebCore/page/RuntimeEnabledFeatures.cpp:116
> +#if ENABLE(DOWNLOAD_ATTRIBUTE)
> +    m_isDownloadAttributeEnabled = false;
> +#endif

Different story here. This is enabled by WebKit2, disabled by WebKit1. reset() previous was not resetting this value. I'll have to do something custom here.
Comment 5 Joseph Pecoraro 2017-01-19 21:59:46 PST 
Created attachment 299316 [details]
[PATCH] Proposed Fix
Comment 6 Joseph Pecoraro 2017-01-19 22:32:32 PST 
Comment on attachment 299316 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=299316&action=review

> Source/WebCore/page/RuntimeEnabledFeatures.cpp:49
>  void RuntimeEnabledFeatures::reset()

This is impossible to make the tests happy when reset is just wrong. I'll remove it battle the failures after removing it (which should be less then battling the failures with it...)
Comment 7 Build Bot 2017-01-19 22:54:35 PST 
Comment on attachment 299316 [details]
[PATCH] Proposed Fix

Attachment 299316 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2918659

Number of test failures exceeded the failure limit.
Comment 8 Build Bot 2017-01-19 22:54:39 PST 
Created attachment 299321 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 9 Build Bot 2017-01-19 23:09:29 PST 
Comment on attachment 299316 [details]
[PATCH] Proposed Fix

Attachment 299316 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2918709

New failing tests:
webgl/webgl2-rendering-context-obtain.html
Comment 10 Build Bot 2017-01-19 23:09:33 PST 
Created attachment 299322 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 11 Build Bot 2017-01-19 23:27:05 PST 
Comment on attachment 299316 [details]
[PATCH] Proposed Fix

Attachment 299316 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2918741

New failing tests:
webgl/webgl2-rendering-context-obtain.html
Comment 12 Build Bot 2017-01-19 23:27:09 PST 
Created attachment 299325 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 13 Joseph Pecoraro 2017-01-20 12:16:53 PST 
Created attachment 299367 [details]
[PATCH] Proposed Fix

I feel pretty good about this one.
Comment 14 Joseph Pecoraro 2017-01-20 13:09:47 PST 
Created attachment 299371 [details]
[PATCH] Proposed Fix

Updated a few tests to new internals APIs.
Updated DRT to better match WTR for experimental features.
Comment 15 Joseph Pecoraro 2017-01-20 13:45:48 PST 
Created attachment 299378 [details]
[PATCH] Proposed Fix

Fixed 1 other test misuse of internals.
Comment 16 Build Bot 2017-01-20 14:09:47 PST 
Comment on attachment 299371 [details]
[PATCH] Proposed Fix

Attachment 299371 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2921924

New failing tests:
fast/dom/navigator-detached-no-crash.html
http/tests/security/cached-cross-origin-preloaded-css-stylesheet.html
Comment 17 Build Bot 2017-01-20 14:09:51 PST 
Created attachment 299380 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 18 Build Bot 2017-01-20 14:25:31 PST 
Comment on attachment 299371 [details]
[PATCH] Proposed Fix

Attachment 299371 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2921989

New failing tests:
http/tests/security/cached-cross-origin-preloaded-css-stylesheet.html
Comment 19 Build Bot 2017-01-20 14:25:35 PST 
Created attachment 299383 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 20 Build Bot 2017-01-20 14:28:58 PST 
Comment on attachment 299371 [details]
[PATCH] Proposed Fix

Attachment 299371 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2921980

New failing tests:
fast/dom/navigator-detached-no-crash.html
http/tests/security/cached-cross-origin-preloaded-css-stylesheet.html
Comment 21 Build Bot 2017-01-20 14:29:03 PST 
Created attachment 299384 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 22 Build Bot 2017-01-20 14:37:08 PST 
Comment on attachment 299371 [details]
[PATCH] Proposed Fix

Attachment 299371 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2922003

New failing tests:
http/tests/security/cached-cross-origin-preloaded-css-stylesheet.html
Comment 23 Build Bot 2017-01-20 14:37:14 PST 
Created attachment 299387 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 24 Build Bot 2017-01-20 14:58:28 PST 
Comment on attachment 299378 [details]
[PATCH] Proposed Fix

Attachment 299378 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2922094

New failing tests:
fast/dom/navigator-detached-no-crash.html
Comment 25 Build Bot 2017-01-20 14:58:33 PST 
Created attachment 299391 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 26 Build Bot 2017-01-20 15:07:16 PST 
Comment on attachment 299378 [details]
[PATCH] Proposed Fix

Attachment 299378 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2922158

New failing tests:
fast/dom/navigator-detached-no-crash.html
Comment 27 Build Bot 2017-01-20 15:07:21 PST 
Created attachment 299393 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 28 Joseph Pecoraro 2017-01-20 15:55:41 PST 
Created attachment 299399 [details]
[PATCH] For Bots
Comment 29 Joseph Pecoraro 2017-01-20 18:19:25 PST 
Bots are green!
Comment 30 Joseph Pecoraro 2017-01-20 18:25:58 PST 
<https://trac.webkit.org/changeset/211006>
Comment 31 Alexey Proskuryakov 2017-01-21 23:45:05 PST 
Looks like this broke js/dom/global-constructors-attributes.html on Sierra WK1:

https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r211025%20(3005)/js/dom/global-constructors-attributes-diff.txt
Comment 32 Joseph Pecoraro 2017-01-22 22:19:41 PST 
(In reply to comment #31)
> Looks like this broke js/dom/global-constructors-attributes.html on Sierra
> WK1:
> 
> https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/
> r211025%20(3005)/js/dom/global-constructors-attributes-diff.txt

Thanks for bringing this to my attention. I'll rebaseline. I think this is a progression, we are enabling experimental features in layout tests. If you think this is incorrect for WebKit1 let me know and I can modify our approach.
Comment 33 Joseph Pecoraro 2017-01-22 22:22:54 PST 
> I'll rebaseline.

<https://trac.webkit.org/changeset/211032>
Comment 34 Joseph Pecoraro 2017-02-09 16:25:09 PST 
*** Bug 167185 has been marked as a duplicate of this bug. ***