Bug 167222 – Migrate font variations tests to using David Jonathan Ross's Boxis font

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

Migrate font variations tests to using David Jonathan Ross's Boxis font

[Myles C. Maxfield]

Created attachment 299292 [details]
Patch

[Build Bot]

Comment on attachment 299292 [details]
Patch

Attachment 299292 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2917728

New failing tests:
fast/text/variations/duplicate.html

[Build Bot]

Created attachment 299304 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Myles C. Maxfield]

Created attachment 299414 [details]
Patch

[Build Bot]

Comment on attachment 299414 [details]
Patch

Attachment 299414 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2923416

New failing tests:
fast/text/variations/duplicate.html

[Build Bot]

Created attachment 299419 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Myles C. Maxfield]

Created attachment 299484 [details]
Patch

[Dean Jackson]

Comment on attachment 299484 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299484&action=review

Why the 0.0000001s?

> LayoutTests/fast/text/variations/outofbounds.html:9
> +<style>
> +@font-face {
> +	font-family: "Boxis";
> +	src: url("resources/Boxis-VF.ttf");
> +}
> +</style>

Maybe you could put this in a separate .css file and <link> it? Although that's not much of a repetition saving.

> LayoutTests/platform/mac/TestExpectations:1433
> +fast/text/variations/order.html [ Pass Crash ]
> +animations/font-variations/font-variation-settings-order.html [ Pass Crash ]

Why does this crash?

[Myles C. Maxfield]

Comment on attachment 299484 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299484&action=review

>> LayoutTests/platform/mac/TestExpectations:1433
>> +animations/font-variations/font-variation-settings-order.html [ Pass Crash ]
> 
> Why does this crash?

Bug in CoreText.

[Myles C. Maxfield]

(In reply to comment #8)
> Comment on attachment 299484 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=299484&action=review
> 
> Why the 0.0000001s?
> 
Bug in CoreText.

[WebKit Commit Bot]

Comment on attachment 299484 [details]
Patch

Clearing flags on attachment: 299484

Committed r211060: <http://trac.webkit.org/changeset/211060>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.