Bug 167222 - Migrate font variations tests to using David Jonathan Ross's Boxis font
Summary: Migrate font variations tests to using David Jonathan Ross's Boxis font
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-19 17:41 PST by Myles C. Maxfield
Modified: 2017-01-23 13:42 PST (History)
5 users (show)

See Also:

Attachments
Patch (47.25 KB, patch)
2017-01-19 17:44 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (9.65 MB, application/zip)
2017-01-19 19:18 PST, Build Bot 		no flags Details
Patch (47.28 KB, patch)
2017-01-20 17:56 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (940.58 KB, application/zip)
2017-01-20 19:31 PST, Build Bot 		no flags Details
Patch (47.26 KB, patch)
2017-01-22 14:29 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2017-01-19 17:41:34 PST 
Migrate font variations tests to using David Jonathan Ross's Boxis font
Comment 1 Myles C. Maxfield 2017-01-19 17:44:18 PST 
Created attachment 299292 [details]
Patch
Comment 2 Build Bot 2017-01-19 19:18:29 PST 
Comment on attachment 299292 [details]
Patch

Attachment 299292 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2917728

New failing tests:
fast/text/variations/duplicate.html
Comment 3 Build Bot 2017-01-19 19:18:32 PST 
Created attachment 299304 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 4 Myles C. Maxfield 2017-01-20 17:56:21 PST 
Created attachment 299414 [details]
Patch
Comment 5 Build Bot 2017-01-20 19:30:59 PST 
Comment on attachment 299414 [details]
Patch

Attachment 299414 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2923416

New failing tests:
fast/text/variations/duplicate.html
Comment 6 Build Bot 2017-01-20 19:31:03 PST 
Created attachment 299419 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 7 Myles C. Maxfield 2017-01-22 14:29:18 PST 
Created attachment 299484 [details]
Patch
Comment 8 Dean Jackson 2017-01-23 13:10:36 PST 
Comment on attachment 299484 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299484&action=review

Why the 0.0000001s?

> LayoutTests/fast/text/variations/outofbounds.html:9
> +<style>
> +@font-face {
> +	font-family: "Boxis";
> +	src: url("resources/Boxis-VF.ttf");
> +}
> +</style>

Maybe you could put this in a separate .css file and <link> it? Although that's not much of a repetition saving.

> LayoutTests/platform/mac/TestExpectations:1433
> +fast/text/variations/order.html [ Pass Crash ]
> +animations/font-variations/font-variation-settings-order.html [ Pass Crash ]

Why does this crash?
Comment 9 Myles C. Maxfield 2017-01-23 13:12:21 PST 
Comment on attachment 299484 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299484&action=review

>> LayoutTests/platform/mac/TestExpectations:1433
>> +animations/font-variations/font-variation-settings-order.html [ Pass Crash ]
> 
> Why does this crash?

Bug in CoreText.
Comment 10 Myles C. Maxfield 2017-01-23 13:12:35 PST 
(In reply to comment #8)
> Comment on attachment 299484 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=299484&action=review
> 
> Why the 0.0000001s?
> 
Bug in CoreText.
Comment 11 WebKit Commit Bot 2017-01-23 13:42:40 PST 
Comment on attachment 299484 [details]
Patch

Clearing flags on attachment: 299484

Committed r211060: <http://trac.webkit.org/changeset/211060>
Comment 12 WebKit Commit Bot 2017-01-23 13:42:45 PST 
All reviewed patches have been landed.  Closing bug.