Bug 167216 - Remove synchronous layout in HTMLTextFormControlElement::setSelectionRange
Summary: Remove synchronous layout in HTMLTextFormControlElement::setSelectionRange
Status: RESOLVED LATER
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-19 15:29 PST by Brent Fulgham
Modified: 2018-02-28 21:22 PST (History)
6 users (show)

See Also:


Attachments
Patch (1.63 KB, patch)
2017-01-19 15:32 PST, Brent Fulgham
fred.wang: review-
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.19 MB, application/zip)
2017-01-19 16:14 PST, Build Bot
no flags Details
Archive of layout-test-results from ews113 for mac-elcapitan (1.92 MB, application/zip)
2017-01-19 16:16 PST, Build Bot
no flags Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (17.83 MB, application/zip)
2017-01-19 16:28 PST, Build Bot
no flags Details
Archive of layout-test-results from ews102 for mac-elcapitan (896.86 KB, application/zip)
2017-01-19 16:33 PST, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2017-01-19 15:29:55 PST
While working on an unrelated bug, I noticed that an extra layout was being performed. This layout had been added as a workaround Bug 128797, which is now fixed.

Rather than perform an unneeded synchronous layout, let's remove it!
Comment 1 Brent Fulgham 2017-01-19 15:32:45 PST
Created attachment 299276 [details]
Patch
Comment 2 Brent Fulgham 2017-01-19 15:33:00 PST
Let's see what EWS thinks of this change!
Comment 3 Build Bot 2017-01-19 16:14:29 PST
Comment on attachment 299276 [details]
Patch

Attachment 299276 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2916845

New failing tests:
fast/forms/input-select-webkit-user-select-none.html
editing/pasteboard/copy-two-pasteboard-types-both-work.html
editing/selection/4975120.html
fast/forms/input-appearance-selection.html
fast/forms/input-delete.html
fast/forms/setrangetext.html
fast/forms/input-placeholder-visibility-2.html
fast/forms/textarea-arrow-navigation.html
editing/selection/5497643.html
editing/selection/shrink-selection-after-shift-pagedown.html
fast/forms/selection-functions.html
Comment 4 Build Bot 2017-01-19 16:14:34 PST
Created attachment 299279 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 5 Brent Fulgham 2017-01-19 16:15:58 PST
Nope! Looks like this won't work.
Comment 6 Brent Fulgham 2017-01-19 16:16:42 PST
Removing the workaround Ryosuke mentioned is not safe (yet).
Comment 7 Build Bot 2017-01-19 16:16:43 PST
Comment on attachment 299276 [details]
Patch

Attachment 299276 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2916847

Number of test failures exceeded the failure limit.
Comment 8 Build Bot 2017-01-19 16:16:48 PST
Created attachment 299280 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 9 Build Bot 2017-01-19 16:28:45 PST
Comment on attachment 299276 [details]
Patch

Attachment 299276 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2916862

New failing tests:
fast/forms/setrangetext.html
editing/selection/4975120.html
fast/forms/input-appearance-selection.html
fast/forms/selection-functions.html
fast/forms/input-delete.html
Comment 10 Build Bot 2017-01-19 16:28:51 PST
Created attachment 299282 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 11 Build Bot 2017-01-19 16:33:01 PST
Comment on attachment 299276 [details]
Patch

Attachment 299276 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2916924

New failing tests:
fast/forms/input-select-webkit-user-select-none.html
editing/pasteboard/copy-two-pasteboard-types-both-work.html
editing/selection/4975120.html
fast/forms/input-appearance-selection.html
fast/forms/input-delete.html
fast/forms/input-placeholder-visibility-2.html
fast/forms/textarea-arrow-navigation.html
editing/selection/shrink-selection-after-shift-pagedown.html
fast/forms/selection-functions.html
Comment 12 Build Bot 2017-01-19 16:33:05 PST
Created attachment 299283 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 13 Frédéric Wang (:fredw) 2018-02-28 07:47:45 PST
Comment on attachment 299276 [details]
Patch

FIXME comment was updated in r224296 but I'm not sure there is a new bug for that.
Comment 14 Ryosuke Niwa 2018-02-28 21:22:16 PST
We need to do more work before we can remove the sync layout there.