Bug 167216 – Remove synchronous layout in HTMLTextFormControlElement::setSelectionRange

• Status: RESOLVED
• Resolution: LATER
• Component: WebCore Misc.

[Brent Fulgham]

While working on an unrelated bug, I noticed that an extra layout was being performed. This layout had been added as a workaround Bug 128797, which is now fixed.

Rather than perform an unneeded synchronous layout, let's remove it!

[Brent Fulgham]

Created attachment 299276 [details]
Patch

[Brent Fulgham]

Let's see what EWS thinks of this change!

[Build Bot]

Comment on attachment 299276 [details]
Patch

Attachment 299276 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2916845

New failing tests:
fast/forms/input-select-webkit-user-select-none.html
editing/pasteboard/copy-two-pasteboard-types-both-work.html
editing/selection/4975120.html
fast/forms/input-appearance-selection.html
fast/forms/input-delete.html
fast/forms/setrangetext.html
fast/forms/input-placeholder-visibility-2.html
fast/forms/textarea-arrow-navigation.html
editing/selection/5497643.html
editing/selection/shrink-selection-after-shift-pagedown.html
fast/forms/selection-functions.html

[Build Bot]

Created attachment 299279 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Brent Fulgham]

Nope! Looks like this won't work.

[Brent Fulgham]

Removing the workaround Ryosuke mentioned is not safe (yet).

[Build Bot]

Comment on attachment 299276 [details]
Patch

Attachment 299276 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2916847

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 299280 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 299276 [details]
Patch

Attachment 299276 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2916862

New failing tests:
fast/forms/setrangetext.html
editing/selection/4975120.html
fast/forms/input-appearance-selection.html
fast/forms/selection-functions.html
fast/forms/input-delete.html

[Build Bot]

Created attachment 299282 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 299276 [details]
Patch

Attachment 299276 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2916924

New failing tests:
fast/forms/input-select-webkit-user-select-none.html
editing/pasteboard/copy-two-pasteboard-types-both-work.html
editing/selection/4975120.html
fast/forms/input-appearance-selection.html
fast/forms/input-delete.html
fast/forms/input-placeholder-visibility-2.html
fast/forms/textarea-arrow-navigation.html
editing/selection/shrink-selection-after-shift-pagedown.html
fast/forms/selection-functions.html

[Build Bot]

Created attachment 299283 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Frédéric Wang (:fredw)]

Comment on attachment 299276 [details]
Patch

FIXME comment was updated in r224296 but I'm not sure there is a new bug for that.

[Ryosuke Niwa]

We need to do more work before we can remove the sync layout there.