Bug 167213 - Don't generate extra scrolling tiles for non-visible pages.
Summary: Don't generate extra scrolling tiles for non-visible pages.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: InRadar, Performance
Depends on:
Blocks:
 
Reported: 2017-01-19 14:14 PST by Andreas Kling
Modified: 2017-04-10 06:49 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.44 KB, patch)
2017-01-19 14:53 PST, Andreas Kling 		simon.fraser: review-
Details | Formatted Diff | Diff
Proposed patch (11.98 KB, patch)
2017-04-10 05:10 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2017-01-19 14:14:02 PST 
We can save both CPU and memory by reducing the tile coverage area for non-visible pages.
Comment 1 Andreas Kling 2017-01-19 14:53:44 PST 
Created attachment 299270 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2017-01-19 14:54:24 PST 
<rdar://problem/30105774>
Comment 3 Simon Fraser (smfr) 2017-01-19 15:15:20 PST 
Comment on attachment 299270 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299270&action=review

Please add a test. You can dump the layer tree including tile caches (LAYER_TREE_INCLUDES_TILE_CACHES). I don't know how to make something not visible (if there isn't a way, add one!).

> Source/WebCore/page/FrameView.h:583
>      void show() final;
> +    void hide() final;

Names so bad (they sounds imperative).

> Source/WebCore/rendering/RenderLayerBacking.cpp:206
> +    if (!backing->owningLayer().renderer().page().isVisible())

Is it cheaper to get to Page via frameView?
Comment 4 Andreas Kling 2017-04-10 05:10:48 PDT 
Created attachment 306684 [details]
Proposed patch
Comment 5 Antti Koivisto 2017-04-10 05:31:49 PDT 
r=me
Comment 6 WebKit Commit Bot 2017-04-10 06:49:22 PDT 
Comment on attachment 306684 [details]
Proposed patch

Clearing flags on attachment: 306684

Committed r215181: <http://trac.webkit.org/changeset/215181>
Comment 7 WebKit Commit Bot 2017-04-10 06:49:23 PDT 
All reviewed patches have been landed.  Closing bug.