Bug 16720 – remove #ifdefs in header/source files and use them in include sites instead

• Status: RESOLVED
• Resolution: INVALID
• Component: WebCore Misc.

[Jan Alonzo]

Hi! 

Attached is a patch to move the #if feature guards outside of the header (and some source) files. This patch is a followup based on the discussion that happened at [1].

This is a work in progress patch. Currently done are database, xpath, and xslt. Feel free to comment/suggest, if any.

Regards

[1] http://lists.webkit.org/pipermail/webkit-dev/2007-December/003062.html

[Jan Alonzo]

Created attachment 18250 [details]
move feature guards out of header/source files

[Jan Alonzo]

Btw, this doesn't suggest that there was a concensus as per the discussion at [1]. The attached patch makes the #if guards consistent with the rest because even if we maintain guards in the header files, afaik there are still some headers (e.g., some autogenerated headers) that need to be guarded in the include site. That is why i opt to just do that instead of making an exception for autogenerated header files.

[David Kilzer (:ddkilzer)]

This patch should also include an update (addition) to the coding style guidelines:

http://webkit.org/coding/coding-style.html

[Jan Alonzo]

ddkilzer, hi! Do you know if this require changes to the different build systems, esp mac and windows? Thanks.

[David Kilzer (:ddkilzer)]

(In reply to comment #4)
> ddkilzer, hi! Do you know if this require changes to the different build
> systems, esp mac and windows? Thanks.

No.  I'm pretty sure these changes will be platform-agnostic since they're all a matter of moving C-preprocessor definitions from source files to header files (or vice-versa, depending on which way we go).

[Jan Alonzo]

This is invalid now as this isn't really how WebKit code is/should be organized.