Bug 167196 - [Threaded Compositor] Initialize the threaded compositor with the current size
Summary: [Threaded Compositor] Initialize the threaded compositor with the current size
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2017-01-19 00:34 PST by Carlos Garcia Campos
Modified: 2017-01-19 22:57 PST (History)
1 user (show)

See Also:


Attachments
Patch (8.61 KB, patch)
2017-01-19 00:43 PST, Carlos Garcia Campos
zan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-01-19 00:34:35 PST
We are always creating the threaded compositor with and empty size and then a sizeDidChange always happen when the backing store state changes. This is always happening because the threaded compositor is created before the first backing store state, but if we wanted to create it later, for example to enter/leave AC mode on demand, the threaded compositor will not have the viewport size unless the window is resized, or sizeDidChange is called manually when entering AC mode. Creating the threaded compositor is sync and changing the size too, so it's better to do both things at the same time using the same sync operation.
Comment 1 Carlos Garcia Campos 2017-01-19 00:43:33 PST
Created attachment 299239 [details]
Patch
Comment 2 Zan Dobersek 2017-01-19 09:08:25 PST
Comment on attachment 299239 [details]
Patch

LGTM.
Comment 3 Carlos Garcia Campos 2017-01-19 22:57:09 PST
Committed r210954: <http://trac.webkit.org/changeset/210954>