Bug 167192 - [iOS] Move the PDF password view into its own class for reuse
Summary: [iOS] Move the PDF password view into its own class for reuse
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-18 20:13 PST by Andy Estes
Modified: 2017-01-19 16:25 PST (History)
4 users (show)

See Also:

Attachments
Patch (24.26 KB, patch)
2017-01-18 20:24 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (24.35 KB, patch)
2017-01-18 20:27 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (25.50 KB, patch)
2017-01-19 14:54 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2017-01-18 20:13:04 PST 
[iOS] Move the PDF password view into its own class for possible reuse
Comment 1 Andy Estes 2017-01-18 20:24:12 PST 
Created attachment 299220 [details]
Patch
Comment 2 Andy Estes 2017-01-18 20:27:43 PST 
Created attachment 299222 [details]
Patch
Comment 3 Alex Christensen 2017-01-18 23:14:24 PST 
Comment on attachment 299222 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299222&action=review

> Source/WebCore/ChangeLog:3
> +        [iOS] Move the PDF password view into its own class for possible reuse

"possible"
lol
Comment 4 Andy Estes 2017-01-19 03:24:28 PST 
(In reply to comment #3)
> Comment on attachment 299222 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=299222&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        [iOS] Move the PDF password view into its own class for possible reuse
> 
> "possible"
> lol

I don't know why I said that :(

Thanks for the review. After thinking more about this, I'd like to take a slightly different approach, so I'll probably post another patch.
Comment 5 Andy Estes 2017-01-19 14:54:06 PST 
Created attachment 299271 [details]
Patch
Comment 6 WebKit Commit Bot 2017-01-19 16:25:07 PST 
Comment on attachment 299271 [details]
Patch

Clearing flags on attachment: 299271

Committed r210943: <http://trac.webkit.org/changeset/210943>
Comment 7 WebKit Commit Bot 2017-01-19 16:25:11 PST 
All reviewed patches have been landed.  Closing bug.