Bug 167189 – [WebIDL] Records should preserve javascript object order

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

[WebIDL] Records should preserve javascript object order

[Sam Weinig]

Created attachment 299215 [details]
Patch

[Sam Weinig]

Created attachment 299217 [details]
Patch

[Build Bot]

Comment on attachment 299217 [details]
Patch

Attachment 299217 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2912884

New failing tests:
js/dom/webidl-type-mapping.html

[Build Bot]

Created attachment 299224 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 299217 [details]
Patch

Attachment 299217 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2912885

New failing tests:
js/dom/webidl-type-mapping.html

[Build Bot]

Created attachment 299226 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 299217 [details]
Patch

Attachment 299217 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2912886

New failing tests:
js/dom/webidl-type-mapping.html

[Build Bot]

Created attachment 299228 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 299217 [details]
Patch

Attachment 299217 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2912889

New failing tests:
js/dom/webidl-type-mapping.html

[Build Bot]

Created attachment 299229 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Yusuke Suzuki]

How about extending ListHashSet to ListHashMap?
ListHashSet preserves insertion order.
Internally, it has a linked list, it chains HashTable's Node.

[Alex Christensen]

Will there be any uses of Records accessing them by key?  If so, we should do that.  If not, this has less overhead.  We won't ever have duplicate keys in a Record, right?

[Alex Christensen]

Comment on attachment 299217 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299217&action=review

> Source/WebCore/ChangeLog:32
> +        * testing/TypeConversions.idl:
> +        Update test IDL to use functions, since the spec mandates that
> +        records can't be used with attributes.

Looks like this broke your test.  Otherwise r=me

[Yusuke Suzuki]

(In reply to comment #12)
> Will there be any uses of Records accessing them by key?  If so, we should
> do that.  If not, this has less overhead.  We won't ever have duplicate keys
> in a Record, right?

Nice catch!
I'm not sure the future use cases. But, at least, in the current use cases, I think it just iterates <key, value> pairs.
For example, in Fetch Standard, record<ByteString, ByteString> is just used to iterate header pairs. So, it seems Vector<> is OK.

[Alex Christensen]

http://trac.webkit.org/r210918