Bug 167183 - WebPageProxy DecidePolicyForNavigationAction and DecidePolicyForResponseSync should be Delayed reply messages
Summary: WebPageProxy DecidePolicyForNavigationAction and DecidePolicyForResponseSync ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
: 167129 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-01-18 16:34 PST by Alex Christensen
Modified: 2017-03-20 20:59 PDT (History)
6 users (show)

See Also:

Attachments
Patch (22.49 KB, patch)
2017-01-18 16:35 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.96 MB, application/zip)
2017-01-18 17:15 PST, Build Bot 		no flags Details
Patch (23.44 KB, patch)
2017-01-19 17:03 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (2.17 MB, application/zip)
2017-01-19 17:44 PST, Build Bot 		no flags Details
Patch (25.20 KB, patch)
2017-03-20 16:40 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (24.95 KB, patch)
2017-03-20 17:14 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-01-18 16:34:37 PST 
WebPageProxy DecidePolicyForNavigationAction and DecidePolicyForResponseSync should be Delayed reply messages
Comment 1 Alex Christensen 2017-01-18 16:35:42 PST 
Created attachment 299202 [details]
Patch
Comment 2 Build Bot 2017-01-18 17:15:55 PST 
Comment on attachment 299202 [details]
Patch

Attachment 299202 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2912153

Number of test failures exceeded the failure limit.
Comment 3 Build Bot 2017-01-18 17:15:57 PST 
Created attachment 299204 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 4 Sam Weinig 2017-01-18 17:21:43 PST 
Can you explain why they should be Delayed reply messages? The ChangeLog really should include that information as well.
Comment 5 Alex Christensen 2017-01-19 17:03:31 PST 
Created attachment 299287 [details]
Patch
Comment 6 Alex Christensen 2017-01-19 17:40:28 PST 
*** Bug 167129 has been marked as a duplicate of this bug. ***
Comment 7 Build Bot 2017-01-19 17:44:31 PST 
Comment on attachment 299287 [details]
Patch

Attachment 299287 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2917363

Number of test failures exceeded the failure limit.
Comment 8 Build Bot 2017-01-19 17:44:34 PST 
Created attachment 299293 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 9 Jessie Berlin 2017-03-20 15:59:22 PDT 
rdar://problem/30203539
Comment 10 Alex Christensen 2017-03-20 16:40:59 PDT 
Created attachment 304966 [details]
Patch
Comment 11 Andy Estes 2017-03-20 16:49:36 PDT 
Comment on attachment 304966 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304966&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:2318
>      m_process->send(Messages::WebPage::DidReceivePolicyDecision(frame.frameID(), listenerID, action, navigation ? navigation->navigationID() : 0, downloadID), m_pageID);

Can you remove this?
Comment 12 Alex Christensen 2017-03-20 17:14:02 PDT 
Created attachment 304971 [details]
Patch
Comment 13 Alex Christensen 2017-03-20 18:14:06 PDT 
http://trac.webkit.org/r214201