Bug 167180 – Use anonymous namespace for DeferredPageDestructor

• Status: RESOLVED
• Resolution: WORKSFORME
• Component: WebKit Website

[Joseph Pecoraro]

Use anonymous namespace for DeferredPageDestructor in WebKit1.

Don't use the WebKit namespace reserved for things in WebKit2.

[Joseph Pecoraro]

Created attachment 299194 [details]
[PATCH] Proposed Fix

[Build Bot]

Comment on attachment 299194 [details]
[PATCH] Proposed Fix

Attachment 299194 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2911849

New failing tests:
imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html

[Build Bot]

Created attachment 299199 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Joseph Pecoraro]

All failures unrelated. Just going to reupload the same patch.

[Joseph Pecoraro]

Created attachment 299203 [details]
[PATCH] Proposed Fix

[Alex Christensen]

Comment on attachment 299203 [details]
[PATCH] Proposed Fix

Why just this?  There are lots of places we have namespace WebKit in WebKit1.  There are even a few places we have comments saying end of namespace WebKit in WebCore, probably from things we moved.

[Chris Dumez]

Comment on attachment 299203 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=299203&action=review

> Source/WebKit/mac/WebView/WebView.mm:585
> +namespace {

I rarely see people using anonymous namespaces in WebKit. I have even seen patches getting rid of them.

[Joseph Pecoraro]

> Why just this?  There are lots of places we have namespace WebKit in
> WebKit1. 

> I rarely see people using anonymous namespaces in WebKit. I have even seen
> patches getting rid of them.

This came up as a late review comment in bug 161746. Since it was trivial to address I put a patch up, but based on feedback I'm going to r- for now.

[Joseph Pecoraro]

I'm going to close this. I don't know of any real issue here.