Bug 167179 - Add instrumentation for when we fail to receive a message
Summary: Add instrumentation for when we fail to receive a message
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-18 15:01 PST by Anders Carlsson
Modified: 2017-01-18 15:24 PST (History)
0 users

See Also:

Attachments
Patch (1.35 KB, patch)
2017-01-18 15:10 PST, Anders Carlsson 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2017-01-18 15:01:32 PST 
Add instrumentation for when we fail to receive a message
Comment 1 Anders Carlsson 2017-01-18 15:10:02 PST 
Created attachment 299193 [details]
Patch
Comment 2 Alexey Proskuryakov 2017-01-18 15:13:27 PST 
Comment on attachment 299193 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299193&action=review

> Source/WebKit2/Platform/IPC/mac/ConnectionMac.mm:500
> +        WKSetCrashReportApplicationSpecificInformation((CFStringRef)[NSString stringWithFormat:@"Unhandled error code %x from mach_msg", kr]);

Should this be inside ASSERT_ENABLED, so that the message doesn't pollute output in release builds?
Comment 3 Anders Carlsson 2017-01-18 15:24:20 PST 
Committed r210892: <http://trac.webkit.org/changeset/210892>