Bug 167174 - REGRESSION(r206156): Animated images are repeated one extra iteration than the value which is saved in the image file
Summary: REGRESSION(r206156): Animated images are repeated one extra iteration than th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-01-18 14:17 PST by Said Abou-Hallawa
Modified: 2017-01-19 19:57 PST (History)
6 users (show)

See Also:

Attachments
red-green-blue-repeat-2.gif (6.40 KB, image/gif)
2017-01-18 14:17 PST, Said Abou-Hallawa 		no flags Details
red-green-blue-repeat-1.gif (6.38 KB, image/gif)
2017-01-18 14:18 PST, Said Abou-Hallawa 		no flags Details
Patch (2.30 KB, patch)
2017-01-18 14:44 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-elcapitan (823.48 KB, application/zip)
2017-01-18 15:39 PST, Build Bot 		no flags Details
Patch (8.09 KB, patch)
2017-01-19 12:13 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (8.09 KB, patch)
2017-01-19 12:26 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (8.55 KB, patch)
2017-01-19 16:18 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (8.55 KB, patch)
2017-01-19 17:22 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (8.86 KB, patch)
2017-01-19 18:07 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2017-01-18 14:17:50 PST 
Created attachment 299180 [details]
red-green-blue-repeat-2.gif

Open the attached files:

1. red-green-blue-repeat-1.gif: loopCount == 1. The image should be animated only once.
2. red-green-blue-repeat-2.gif: loopCount == 2. The image should be animated twice.

RESULT: All images are animated one extra iteration than what it should do.

NOTICE: This regression affects the case where loopCount == 1 or the case when it is missing from the file. For the cases loopCount > 1, the bug did exist before this regression.
Comment 1 Said Abou-Hallawa 2017-01-18 14:18:19 PST 
Created attachment 299181 [details]
red-green-blue-repeat-1.gif
Comment 2 Said Abou-Hallawa 2017-01-18 14:44:35 PST 
Created attachment 299187 [details]
Patch
Comment 3 Said Abou-Hallawa 2017-01-18 14:44:57 PST 
Working on a layout test.
Comment 4 Build Bot 2017-01-18 15:39:51 PST 
Comment on attachment 299187 [details]
Patch

Attachment 299187 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2911712

New failing tests:
imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html
Comment 5 Build Bot 2017-01-18 15:39:55 PST 
Created attachment 299196 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 Simon Fraser (smfr) 2017-01-18 16:08:49 PST 
Comment on attachment 299187 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299187&action=review

> Source/WebCore/ChangeLog:10
> +        all other cases. Having repetitionCount() returns zero for loopCount = 1

"Having repetitionCount() return zero"

> Source/WebCore/ChangeLog:12
> +        breaks the animation loop after one iteration. But it was wrong for all

"break"
Comment 7 Simon Fraser (smfr) 2017-01-18 16:09:07 PST 
Comment on attachment 299187 [details]
Patch

Can we test this?
Comment 8 Said Abou-Hallawa 2017-01-19 12:13:19 PST 
Created attachment 299258 [details]
Patch
Comment 9 Said Abou-Hallawa 2017-01-19 12:26:50 PST 
Created attachment 299260 [details]
Patch
Comment 10 Said Abou-Hallawa 2017-01-19 16:18:12 PST 
Created attachment 299281 [details]
Patch
Comment 11 Radar WebKit Bug Importer 2017-01-19 16:18:41 PST 
<rdar://problem/30107642>
Comment 12 Said Abou-Hallawa 2017-01-19 16:19:21 PST 
Comment on attachment 299281 [details]
Patch

The layout test is cleaned a little.
Comment 13 Said Abou-Hallawa 2017-01-19 17:22:14 PST 
Created attachment 299291 [details]
Patch
Comment 14 Said Abou-Hallawa 2017-01-19 18:07:30 PST 
Created attachment 299296 [details]
Patch
Comment 15 Said Abou-Hallawa 2017-01-19 18:09:23 PST 
Comment on attachment 299296 [details]
Patch

Using <h2> in the layout test caused it to fail on ios-simulator. Changing it to <p> seems to fix the issue locally.
Comment 16 WebKit Commit Bot 2017-01-19 19:57:32 PST 
Comment on attachment 299296 [details]
Patch

Clearing flags on attachment: 299296

Committed r210951: <http://trac.webkit.org/changeset/210951>
Comment 17 WebKit Commit Bot 2017-01-19 19:57:38 PST 
All reviewed patches have been landed.  Closing bug.