167160 – [Modern Media Controls] Hiding controls, changing their width and showing them again shows an incorrect layout

Bug 167160 - [Modern Media Controls] Hiding controls, changing their width and showing them again shows an incorrect layout

Summary: [Modern Media Controls] Hiding controls, changing their width and showing the...

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Media (show other bugs)
Version:	Safari Technology Preview
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Antoine Quint

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2017-01-18 06:43 PST by Antoine Quint
Modified:	2017-01-26 06:59 PST (History)
CC List:	4 users (show)

See Also:

Attachments
Patch (8.16 KB, patch) 2017-01-18 06:48 PST, Antoine Quint	no flags	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews102 for mac-elcapitan (854.20 KB, application/zip) 2017-01-18 07:48 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (826.25 KB, application/zip) 2017-01-18 08:02 PST, Build Bot	no flags	Details
Patch for landing (8.05 KB, patch) 2017-01-26 06:22 PST, Antoine Quint	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Antoine Quint 2017-01-18 06:43:18 PST

Since layout of inline media controls on macOS only happen when the controls bar is visible, changing the width of inline media controls when controls are invisible, and then showing them again yields and incorrect layout.

Comment 1 Antoine Quint 2017-01-18 06:43:46 PST

<rdar://problem/29612318>

Comment 2 Antoine Quint 2017-01-18 06:48:29 PST

Created attachment 299140 [details]
Patch

Comment 3 Build Bot 2017-01-18 07:48:25 PST

Comment on attachment 299140 [details]
Patch

Attachment 299140 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2909831

New failing tests:
fast/hidpi/video-controls-in-hidpi.html

Comment 4 Build Bot 2017-01-18 07:48:28 PST

Created attachment 299144 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 5 Build Bot 2017-01-18 08:02:05 PST

Comment on attachment 299140 [details]
Patch

Attachment 299140 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2909843

New failing tests:
media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-resize-with-hidden-controls-bar.html

Comment 6 Build Bot 2017-01-18 08:02:07 PST

Created attachment 299145 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

Comment 7 Antoine Quint 2017-01-26 06:22:41 PST

Created attachment 299805 [details]
Patch for landing

Comment 8 WebKit Commit Bot 2017-01-26 06:59:29 PST

Comment on attachment 299805 [details]
Patch for landing

Clearing flags on attachment: 299805

Committed r211209: <http://trac.webkit.org/changeset/211209>

Comment 9 WebKit Commit Bot 2017-01-26 06:59:33 PST

All reviewed patches have been landed.  Closing bug.