Bug 167160 – [Modern Media Controls] Hiding controls, changing their width and showing them again shows an incorrect layout

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Antoine Quint]

Since layout of inline media controls on macOS only happen when the controls bar is visible, changing the width of inline media controls when controls are invisible, and then showing them again yields and incorrect layout.

[Antoine Quint]

<rdar://problem/29612318>

[Antoine Quint]

Created attachment 299140 [details]
Patch

[Build Bot]

Comment on attachment 299140 [details]
Patch

Attachment 299140 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2909831

New failing tests:
fast/hidpi/video-controls-in-hidpi.html

[Build Bot]

Created attachment 299144 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 299140 [details]
Patch

Attachment 299140 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2909843

New failing tests:
media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-resize-with-hidden-controls-bar.html

[Build Bot]

Created attachment 299145 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Antoine Quint]

Created attachment 299805 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 299805 [details]
Patch for landing

Clearing flags on attachment: 299805

Committed r211209: <http://trac.webkit.org/changeset/211209>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.