'buildbot-syncer.js' should be able to determine force build argument from a list of possible repositories.
Created attachment 299115 [details] Patch
Comment on attachment 299115 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299115&action=review r=me assuming all the issues below are addressed. > Websites/perf.webkit.org/tools/js/buildbot-syncer.js:231 > + for (let rootCandidate of value['rootCandidates']) { > + if(!(rootCandidate in repositoryByName)) > + continue; We should just use filter instead. e.g. const filteredOptions = value['rootOptions'].filter((option) => option in repositoryByName); and then check that the filtered result is of length 1. > Websites/perf.webkit.org/tools/js/buildbot-syncer.js:394 > + case 'rootCandidates': //fallthrough Nit: Capitalize f and there should be a space between // and f. > Websites/perf.webkit.org/unit-tests/buildbot-syncer-tests.js:19 > + 'opensource': {'rootCandidates': ['WebKit-SVN', 'WebKit-Git']}, I don't think the term "candidate" makes sense given we're picking one of them. How about 'rootOptions' or 'rootChoices'? > Websites/perf.webkit.org/unit-tests/resources/mock-v3-models.js:21 > + MockModels.opensourceRepository = Repository.ensureSingleton(17, {name: 'WebKit-Git'}); I don't think we want to call this opensourceRepository. Probably something like webkitGit?
Created attachment 299214 [details] Patch for landing
Comment on attachment 299214 [details] Patch for landing Clearing flags on attachment: 299214 Committed r210909: <http://trac.webkit.org/changeset/210909>
All reviewed patches have been landed. Closing bug.