Bug 167151 - Make calls to render() functions async
Summary: Make calls to render() functions async
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-17 19:43 PST by Ryosuke Niwa
Modified: 2017-01-18 13:23 PST (History)
4 users (show)

See Also:


Attachments
Improves efficiency (67.39 KB, patch)
2017-01-17 20:28 PST, Ryosuke Niwa
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2017-01-17 19:43:58 PST
Right now, perf dashboard synchronously calls render() functions in various places.
This turns out to be problematic when the top-level component keeps updating descendent components.

For example, during a single load of the summary page on our internal dashboard,
we called render() function 9444 times!

Make these calls async so that we don't end up doing O(n^2) work.
Comment 1 Ryosuke Niwa 2017-01-17 20:28:13 PST
Created attachment 299114 [details]
Improves efficiency
Comment 2 Ryosuke Niwa 2017-01-18 13:23:49 PST
Committed r210880: <http://trac.webkit.org/changeset/210880>