Bug 167146 - Web Inspector: "bouncy highlight" element in TextEditor/DOMTreeOutline should update or dismiss when user scrolls
Summary: Web Inspector: "bouncy highlight" element in TextEditor/DOMTreeOutline should...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-01-17 16:39 PST by BJ Burg
Modified: 2017-01-30 23:13 PST (History)
5 users (show)

See Also:


Attachments
Patch (2.13 KB, patch)
2017-01-30 15:00 PST, Devin Rousso
timothy: review+
Details | Formatted Diff | Diff
Patch (2.00 KB, patch)
2017-01-30 22:34 PST, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (2.00 KB, patch)
2017-01-30 22:35 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2017-01-17 16:39:52 PST
This looks dumb. Should be easy to fix. Relevant code is in 

TextEditor._revealSearchResult

and you could use add/removeScrollHandler to detect this and update position or hide it early. You'd need to make sure the animation cancels.
Comment 1 BJ Burg 2017-01-17 16:40:28 PST
<rdar://problem/14222375>
Comment 2 Devin Rousso 2017-01-30 14:51:49 PST
Not sure if I'm just missing something obvious, but what is the "bouncy highlight" element?  Do you mean the light-blue line highlight?
Comment 3 Devin Rousso 2017-01-30 14:58:44 PST
(In reply to comment #2)
> Not sure if I'm just missing something obvious, but what is the "bouncy
> highlight" element?  Do you mean the light-blue line highlight?

Yeah that was a dumb question.  Nevermind -.-
Comment 4 Devin Rousso 2017-01-30 15:00:21 PST
Created attachment 300147 [details]
Patch
Comment 5 Timothy Hatcher 2017-01-30 19:50:57 PST
Comment on attachment 300147 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300147&action=review

> Source/WebInspectorUI/UserInterface/Views/TextEditor.js:1093
> +        };
> +        this.addScrollHandler(scrollHandler);

Add newline between.
Comment 6 Devin Rousso 2017-01-30 22:34:51 PST
Created attachment 300187 [details]
Patch
Comment 7 Devin Rousso 2017-01-30 22:35:41 PST
Created attachment 300188 [details]
Patch
Comment 8 WebKit Commit Bot 2017-01-30 23:13:09 PST
Comment on attachment 300188 [details]
Patch

Clearing flags on attachment: 300188

Committed r211408: <http://trac.webkit.org/changeset/211408>
Comment 9 WebKit Commit Bot 2017-01-30 23:13:12 PST
All reviewed patches have been landed.  Closing bug.