Bug 167146 – Web Inspector: "bouncy highlight" element in TextEditor/DOMTreeOutline should update or dismiss when user scrolls

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

This looks dumb. Should be easy to fix. Relevant code is in 

TextEditor._revealSearchResult

and you could use add/removeScrollHandler to detect this and update position or hide it early. You'd need to make sure the animation cancels.

[Blaze Burg]

<rdar://problem/14222375>

[Devin Rousso]

Not sure if I'm just missing something obvious, but what is the "bouncy highlight" element?  Do you mean the light-blue line highlight?

[Devin Rousso]

(In reply to comment #2)
> Not sure if I'm just missing something obvious, but what is the "bouncy
> highlight" element?  Do you mean the light-blue line highlight?

Yeah that was a dumb question.  Nevermind -.-

[Devin Rousso]

Created attachment 300147 [details]
Patch

[Timothy Hatcher]

Comment on attachment 300147 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300147&action=review

> Source/WebInspectorUI/UserInterface/Views/TextEditor.js:1093
> +        };
> +        this.addScrollHandler(scrollHandler);

Add newline between.

[Devin Rousso]

Created attachment 300187 [details]
Patch

[Devin Rousso]

Created attachment 300188 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 300188 [details]
Patch

Clearing flags on attachment: 300188

Committed r211408: <http://trac.webkit.org/changeset/211408>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.