Bug 167139 - An update to one gamepad's values should only change that gamepad's modified timestamp
Summary: An update to one gamepad's values should only change that gamepad's modified ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-01-17 14:52 PST by Brady Eidson
Modified: 2017-01-17 15:34 PST (History)
0 users

See Also:

Attachments
Patch (8.94 KB, patch)
2017-01-17 15:25 PST, Brady Eidson 		aestes: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2017-01-17 14:52:15 PST 
An update to one gamepad's values should only change that gamepad's modified timestamp

<rdar://problem/28620865>
Comment 1 Brady Eidson 2017-01-17 15:23:33 PST 
(This only affects WK2 AFAIK)
Comment 2 Brady Eidson 2017-01-17 15:25:44 PST 
Created attachment 299072 [details]
Patch
Comment 3 Andy Estes 2017-01-17 15:31:26 PST 
Comment on attachment 299072 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299072&action=review

> Source/WebKit2/Shared/Gamepad/GamepadData.h:66
> +    double m_lastUpdateTime;

Should probably initialize this to 0 for the default constructor case, even though I'm guessing you'll never read this value if m_isNull is true.
Comment 4 Brady Eidson 2017-01-17 15:34:42 PST 
https://trac.webkit.org/changeset/210827