WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
167139
An update to one gamepad's values should only change that gamepad's modified timestamp
https://bugs.webkit.org/show_bug.cgi?id=167139
Summary
An update to one gamepad's values should only change that gamepad's modified ...
Brady Eidson
Reported
2017-01-17 14:52:15 PST
An update to one gamepad's values should only change that gamepad's modified timestamp <
rdar://problem/28620865
>
Attachments
Patch
(8.94 KB, patch)
2017-01-17 15:25 PST
,
Brady Eidson
aestes
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Brady Eidson
Comment 1
2017-01-17 15:23:33 PST
(This only affects WK2 AFAIK)
Brady Eidson
Comment 2
2017-01-17 15:25:44 PST
Created
attachment 299072
[details]
Patch
Andy Estes
Comment 3
2017-01-17 15:31:26 PST
Comment on
attachment 299072
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=299072&action=review
> Source/WebKit2/Shared/Gamepad/GamepadData.h:66 > + double m_lastUpdateTime;
Should probably initialize this to 0 for the default constructor case, even though I'm guessing you'll never read this value if m_isNull is true.
Brady Eidson
Comment 4
2017-01-17 15:34:42 PST
https://trac.webkit.org/changeset/210827
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug