Bug 167134 – Pointer lock events should be delivered directly to the target element

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Jeremy Jones]

Pointer lock events should be delivered directly to the target element

[Jeremy Jones]

rdar://problem/30058933

[Jeremy Jones]

Created attachment 299055 [details]
Patch

[Jon Lee]

Comment on attachment 299055 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299055&action=review

> LayoutTests/pointer-lock/mouse-event-delivery.html:50
> +                window.eventSender.mouseMoveTo(20,20);

why does this need to be added?

[Jeremy Jones]

Created attachment 299785 [details]
Patch

[Jeremy Jones]

(In reply to comment #3)
> Comment on attachment 299055 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=299055&action=review
> 
> > LayoutTests/pointer-lock/mouse-event-delivery.html:50
> > +                window.eventSender.mouseMoveTo(20,20);
> 
> why does this need to be added?

        The pointer-lock/mouse-event-delivery.html test is modified to explicitly move the mouse pointer to a valid
        location before sending mouse actions. Without this, the test infrastructure doesn't know that the pointer
        is over the web view and doesn't deliver events.

[Jeremy Jones]

*** Bug 167133 has been marked as a duplicate of this bug. ***

[WebKit Commit Bot]

Comment on attachment 299785 [details]
Patch

Clearing flags on attachment: 299785

Committed r211235: <http://trac.webkit.org/changeset/211235>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

*** Bug 167511 has been marked as a duplicate of this bug. ***

[Ryan Haddad]

Rolled out the change in http://trac.webkit.org/projects/webkit/changeset/211375 due to frequent LayoutTest failures.

[Jeremy Jones]

Created attachment 300467 [details]
Patch

[Jeremy Jones]

rdar://problem/30268004

[Jeremy Jones]

Created attachment 300470 [details]
Patch

[Dean Jackson]

Comment on attachment 300470 [details]
Patch

I assume this is adding the same things that we do for touchmove and related events?

[WebKit Commit Bot]

Comment on attachment 300470 [details]
Patch

Clearing flags on attachment: 300470

Committed r211650: <http://trac.webkit.org/changeset/211650>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

The test for this change still appears to be a flaky failure: 

https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r211723%20(1910)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=pointer-lock%2Fmouse-event-delivery.html