Bug 167130 - Web Inspector: Tooltip text should not end in a period
Summary: Web Inspector: Tooltip text should not end in a period
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
Depends on:
Reported: 2017-01-17 12:00 PST by Matt Baker
Modified: 2017-01-31 17:28 PST (History)
3 users (show)

See Also:

Patch (52.33 KB, patch)
2017-01-17 13:19 PST, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (42.51 KB, patch)
2017-01-31 10:17 PST, Devin Rousso
bburg: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch (41.12 KB, patch)
2017-01-31 16:50 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2017-01-17 12:00:47 PST
Tooltip text should not end in a period. Per Apple's HI guidelines, prefer sentence fragments over complete sentences for help tags (tooltips):

Comment 1 Devin Rousso 2017-01-17 13:19:21 PST
Created attachment 299057 [details]
Comment 2 BJ Burg 2017-01-31 07:46:58 PST
Comment on attachment 299057 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=299057&action=review

I think the intent of this bug was a little vague. I tried to add some more specific pointers. Should be easy to fix up.

> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:270
> +localizedStrings["Edit cubic-bezier"] = "Edit cubic-bezier";

Edit 'cubic-bezier' function

> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:271
> +localizedStrings["Edit spring"] = "Edit spring";

Edit 'spring' function

> Source/WebInspectorUI/UserInterface/Models/DatabaseObject.js:-74
> -                    errorCallback(WebInspector.UIString("Database no longer has expected version."));

I don't think these strings should be changed if they are simply UIStrings for error messages. Do these have tooltips as well?

I am mainly concerned about button/action labels. These are neither.

> Source/WebInspectorUI/UserInterface/Models/Resource.js:657
>          if (this._failed)


> Source/WebInspectorUI/UserInterface/Models/SourceMapResource.js:-97
> -                error: WebInspector.UIString("An error occurred trying to load the resource."),


> Source/WebInspectorUI/UserInterface/Models/SourceMapResource.js:-109
> -            return Promise.resolve({error: WebInspector.UIString("An error occurred trying to load the resource.")});


> Source/WebInspectorUI/UserInterface/Views/DatabaseContentView.js:117
> +            message = WebInspector.UIString("Unexpected database version");


> Source/WebInspectorUI/UserInterface/Views/DatabaseTableContentView.js:112
> +        this._messageTextViewElement = WebInspector.createMessageTextView(WebInspector.UIString("Error reading â%sâ table").format(this.representedObject.name), true);


> Source/WebInspectorUI/UserInterface/Views/DatabaseUserQuerySuccessView.js:-41
> -            this.resultElement.textContent = WebInspector.UIString("Query returned no results.");


> Source/WebInspectorUI/UserInterface/Views/InlineSwatch.js:-40
> -            this._swatchElement.title = WebInspector.UIString("Click to open a cubic-bezier editor.");

I prefer:

Edit 'cubic-bezier' function
Edit 'spring' function
Edit custom gradient

> Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js:-113
> -        this._contentError(WebInspector.UIString("An error occurred trying to load the resource."));


> Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js:-307
> -                descriptionElement.textContent = WebInspector.UIString("Resource failed to load.");


> Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorSection.js:62
> +        let addGlyphElement = useSVGSymbol("Images/Plus13.svg", "visual-style-selector-section-add-rule", WebInspector.UIString("New Rule"));

"Add new rule"

> Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorTreeItem.js:227
> +            this._checkboxElement.title = WebInspector.UIString("Disable Rule");

How about: "Comment out rule" / "Uncomment rule"
Comment 3 Devin Rousso 2017-01-31 10:17:52 PST
Created attachment 300229 [details]
Comment 4 BJ Burg 2017-01-31 16:02:27 PST
Comment on attachment 300229 [details]

r=me, thanks Devin!
Comment 5 WebKit Commit Bot 2017-01-31 16:05:23 PST
Comment on attachment 300229 [details]

Rejecting attachment 300229 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 300229, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
hing file Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyEditorLink.js
patching file Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyNameInput.js
patching file Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorSection.js
patching file Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorTreeItem.js

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Brian Burg']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/2981889
Comment 6 Devin Rousso 2017-01-31 16:50:55 PST
Created attachment 300284 [details]
Comment 7 WebKit Commit Bot 2017-01-31 17:28:23 PST
Comment on attachment 300284 [details]

Clearing flags on attachment: 300284

Committed r211462: <http://trac.webkit.org/changeset/211462>
Comment 8 WebKit Commit Bot 2017-01-31 17:28:27 PST
All reviewed patches have been landed.  Closing bug.