WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
167124
Document::securityOrigin() should return a reference.
https://bugs.webkit.org/show_bug.cgi?id=167124
Summary
Document::securityOrigin() should return a reference.
Andreas Kling
Reported
2017-01-17 10:21:50 PST
Excluding a tiny time window during construction, Document always has a SecurityOrigin. Let's make securityOrigin() return a reference.
Attachments
Patch for EWS
(123.07 KB, patch)
2017-01-17 10:27 PST
,
Andreas Kling
no flags
Details
Formatted Diff
Diff
Patch for EWS II
(124.88 KB, patch)
2017-01-17 17:01 PST
,
Andreas Kling
no flags
Details
Formatted Diff
Diff
Patch for EWS III
(127.54 KB, patch)
2017-01-17 17:46 PST
,
Andreas Kling
buildbot
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from ews100 for mac-elcapitan
(814.44 KB, application/zip)
2017-01-17 18:59 PST
,
Build Bot
no flags
Details
Patch
(142.04 KB, patch)
2017-01-17 22:34 PST
,
Andreas Kling
no flags
Details
Formatted Diff
Diff
Patch
(140.31 KB, patch)
2017-01-18 07:41 PST
,
Andreas Kling
sam
: review+
Details
Formatted Diff
Diff
Patch for landing
(141.75 KB, patch)
2017-01-18 09:25 PST
,
Andreas Kling
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews100 for mac-elcapitan
(766.62 KB, application/zip)
2017-01-18 10:44 PST
,
Build Bot
no flags
Details
Show Obsolete
(6)
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2017-01-17 10:27:53 PST
Created
attachment 299041
[details]
Patch for EWS
WebKit Commit Bot
Comment 2
2017-01-17 10:31:00 PST
Attachment 299041
[details]
did not pass style-queue: ERROR: Source/WebKit/mac/Plugins/WebPluginContainerCheck.mm:102: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 90 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3
2017-01-17 17:01:35 PST
Created
attachment 299088
[details]
Patch for EWS II
WebKit Commit Bot
Comment 4
2017-01-17 17:03:22 PST
Attachment 299088
[details]
did not pass style-queue: ERROR: Source/WebKit/mac/Plugins/WebPluginContainerCheck.mm:102: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 92 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 5
2017-01-17 17:46:50 PST
Created
attachment 299093
[details]
Patch for EWS III
Build Bot
Comment 6
2017-01-17 18:58:56 PST
Comment on
attachment 299093
[details]
Patch for EWS III
Attachment 299093
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.webkit.org/results/2906889
New failing tests: imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html
Build Bot
Comment 7
2017-01-17 18:59:00 PST
Created
attachment 299108
[details]
Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Andreas Kling
Comment 8
2017-01-17 22:34:34 PST
Created
attachment 299120
[details]
Patch
Andreas Kling
Comment 9
2017-01-18 07:41:16 PST
Created
attachment 299143
[details]
Patch
Andreas Kling
Comment 10
2017-01-18 09:25:49 PST
Created
attachment 299149
[details]
Patch for landing
Build Bot
Comment 11
2017-01-18 10:44:46 PST
Comment on
attachment 299149
[details]
Patch for landing
Attachment 299149
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.webkit.org/results/2910422
New failing tests: imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html
Build Bot
Comment 12
2017-01-18 10:44:48 PST
Created
attachment 299156
[details]
Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Andreas Kling
Comment 13
2017-01-18 11:11:16 PST
Comment on
attachment 299149
[details]
Patch for landing Test appears to be EWS hiccup
WebKit Commit Bot
Comment 14
2017-01-18 11:37:01 PST
Comment on
attachment 299149
[details]
Patch for landing Clearing flags on attachment: 299149 Committed
r210859
: <
http://trac.webkit.org/changeset/210859
>
WebKit Commit Bot
Comment 15
2017-01-18 11:37:06 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 16
2017-05-04 18:03:30 PDT
<
rdar://problem/32005222
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug