Bug 167104 - [QuickLook] QLPreviewConverter should be owned by its delegate
Summary: [QuickLook] QLPreviewConverter should be owned by its delegate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-16 18:36 PST by Andy Estes
Modified: 2017-01-16 19:55 PST (History)
8 users (show)

See Also:

Attachments
Patch (12.09 KB, patch)
2017-01-16 18:46 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (12.07 KB, patch)
2017-01-16 19:17 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2017-01-16 18:36:52 PST 
[QuickLook] QLPreviewConverter should be owned by its delegate
Comment 1 Andy Estes 2017-01-16 18:46:23 PST 
Created attachment 299007 [details]
Patch
Comment 2 WebKit Commit Bot 2017-01-16 18:48:18 PST 
Attachment 299007 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/ios/QuickLook.mm:331:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/loader/ios/QuickLook.mm:356:  Extra space in capture list.  [whitespace/brackets] [4]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2017-01-16 18:59:25 PST 
Comment on attachment 299007 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299007&action=review

> Source/WebCore/loader/ios/QuickLook.mm:183
> +    static auto& emptyClient = adoptRef(*new QuickLookHandleClient()).leakRef();

It would be nice to use NeverDestroyed here to avoid the permanent heap allocation.
Comment 4 Andy Estes 2017-01-16 19:17:13 PST 
Created attachment 299012 [details]
Patch
Comment 5 WebKit Commit Bot 2017-01-16 19:55:06 PST 
Comment on attachment 299012 [details]
Patch

Clearing flags on attachment: 299012

Committed r210796: <http://trac.webkit.org/changeset/210796>
Comment 6 WebKit Commit Bot 2017-01-16 19:55:11 PST 
All reviewed patches have been landed.  Closing bug.