Bug 167089 - [SOUP] Accept-language could be set twice in a row for the default context
Summary: [SOUP] Accept-language could be set twice in a row for the default context
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Soup
Depends on:
Blocks:
 
Reported: 2017-01-16 03:37 PST by Carlos Garcia Campos
Modified: 2017-01-16 07:35 PST (History)
3 users (show)

See Also:

Attachments
Patch (12.01 KB, patch)
2017-01-16 03:43 PST, Carlos Garcia Campos 		zan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-01-16 03:37:53 PST 
If NetworkStorageSession doesn't have a SoupNetworkSession yet, we are creating it only to set the languages. Since we already set the global value, the languages will be set when the  SoupNetworkSession is created later. This is not a big deal for the language property, but it will be for proxies after bug #128674.
Comment 1 Carlos Garcia Campos 2017-01-16 03:43:47 PST 
Created attachment 298950 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-01-16 03:51:32 PST 
Committed r210786: <http://trac.webkit.org/changeset/210786>
Comment 3 Michael Catanzaro 2017-01-16 07:35:08 PST 
It's way too much typing to get the SoupNetworkSession in the normal case where you don't care if you create it or not. :(