RESOLVED FIXED 167076
Web Inspector: Attributes table in Node Details Sidebar should have editable keys and values 
https://bugs.webkit.org/show_bug.cgi?id=167076
Summary Web Inspector: Attributes table in Node Details Sidebar should have editable ...
Blaze Burg
Reported 2017-01-15 14:32:41 PST
We support adding/removing/updating attributes in the DOMTreeOutline, but this is often annoying to edit due to wrapping the tree element. It's also not accessible at all. We should allow editing properties via the sidebar as well.
Attachments
Patch (12.13 KB, patch)
2017-05-25 12:15 PDT, Devin Rousso 		timothy: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (12.29 MB, application/zip)
2017-05-25 13:24 PDT, Build Bot 		no flags
Details
Patch (11.82 KB, patch)
2017-06-02 16:20 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-01-15 14:33:10 PST
<rdar://problem/30033629>
Devin Rousso
Comment 2 2017-05-25 12:15:26 PDT
Created attachment 311261 [details] Patch
Build Bot
Comment 3 2017-05-25 13:24:17 PDT
Comment on attachment 311261 [details] Patch Attachment 311261 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3815953 New failing tests: http/tests/cache/cancel-during-revalidation-succeeded.html
Build Bot
Comment 4 2017-05-25 13:24:19 PDT
Created attachment 311279 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Timothy Hatcher
Comment 5 2017-06-02 10:18:06 PDT
Comment on attachment 311261 [details] Patch Looks good!
Devin Rousso
Comment 6 2017-06-02 16:20:05 PDT
Created attachment 311882 [details] Patch
WebKit Commit Bot
Comment 7 2017-06-02 16:58:43 PDT
Comment on attachment 311882 [details] Patch Clearing flags on attachment: 311882 Committed r217744: <http://trac.webkit.org/changeset/217744>
WebKit Commit Bot
Comment 8 2017-06-02 16:58:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.