Bug 167076 - Web Inspector: Attributes table in Node Details Sidebar should have editable keys and values
Summary: Web Inspector: Attributes table in Node Details Sidebar should have editable ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-01-15 14:32 PST by BJ Burg
Modified: 2017-06-02 16:58 PDT (History)
6 users (show)

See Also:


Attachments
Patch (12.13 KB, patch)
2017-05-25 12:15 PDT, Devin Rousso
timothy: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (12.29 MB, application/zip)
2017-05-25 13:24 PDT, Build Bot
no flags Details
Patch (11.82 KB, patch)
2017-06-02 16:20 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2017-01-15 14:32:41 PST
We support adding/removing/updating attributes in the DOMTreeOutline, but this is often annoying to edit due to wrapping the tree element. It's also not accessible at all. We should allow editing properties via the sidebar as well.
Comment 1 Radar WebKit Bug Importer 2017-01-15 14:33:10 PST
<rdar://problem/30033629>
Comment 2 Devin Rousso 2017-05-25 12:15:26 PDT
Created attachment 311261 [details]
Patch
Comment 3 Build Bot 2017-05-25 13:24:17 PDT
Comment on attachment 311261 [details]
Patch

Attachment 311261 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3815953

New failing tests:
http/tests/cache/cancel-during-revalidation-succeeded.html
Comment 4 Build Bot 2017-05-25 13:24:19 PDT
Created attachment 311279 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 5 Timothy Hatcher 2017-06-02 10:18:06 PDT
Comment on attachment 311261 [details]
Patch

Looks good!
Comment 6 Devin Rousso 2017-06-02 16:20:05 PDT
Created attachment 311882 [details]
Patch
Comment 7 WebKit Commit Bot 2017-06-02 16:58:43 PDT
Comment on attachment 311882 [details]
Patch

Clearing flags on attachment: 311882

Committed r217744: <http://trac.webkit.org/changeset/217744>
Comment 8 WebKit Commit Bot 2017-06-02 16:58:44 PDT
All reviewed patches have been landed.  Closing bug.