Bug 167074 – Web Inspector: copying a search result out of Search Tab navigation sidebar does nothing

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

STEPS TO REPRODUCE:

1. Open inspector
2. Search for something.
3. Select a search result
4. Cmd-C
=> Nothing copied to clipboard

Xcode uses the following format:

`${url}:${lineno}:${resultLine}`

/Users/bburg/repos/webkit/OpenSource/Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:293:# define YYUSE(E) /* empty */


When a resource tree element is selected it multi-selects all results in the resource, which we can't quite do yet with TreeOutline. But copying the resource tree element should probably copy all results underneath it.

[Radar WebKit Bug Importer]

<rdar://problem/30033607>

[Blaze Burg]

It is typical to have a Copy shortcut menu command as well.

[Devin Rousso]

Created attachment 301684 [details]
Patch

[Matt Baker]

(In reply to comment #3)
> Created attachment 301684 [details]
> Patch

Copying results from minified files can essentially copy the entire file to the clipboard. Is this what we want?

[Blaze Burg]

Comment on attachment 301684 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 301684 [details]
Patch

Rejecting attachment 301684 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 301684, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
w3c/ChangeLog
	M	Source/WebCore/html/HTMLMediaElement.cpp
	M	Source/WebCore/html/HTMLVideoElement.h
	M	Source/WebCore/loader/MediaResourceLoader.cpp
	M	Source/WebCore/loader/MediaResourceLoader.h
	M	Source/WebCore/ChangeLog
	M	Tools/TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm
	M	Tools/ChangeLog
r212994 = cbb24f84557d16b14c9fb853b0e839466e4f26be (refs/remotes/origin/master)
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/3189917

[Devin Rousso]

Created attachment 302747 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 302747 [details]
Patch

Clearing flags on attachment: 302747

Committed r213000: <http://trac.webkit.org/changeset/213000>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.