Bug 167074 - Web Inspector: copying a search result out of Search Tab navigation sidebar does nothing
Summary: Web Inspector: copying a search result out of Search Tab navigation sidebar d...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-01-15 14:21 PST by BJ Burg
Modified: 2017-02-25 00:31 PST (History)
5 users (show)

See Also:


Attachments
Patch (4.63 KB, patch)
2017-02-15 18:02 PST, Devin Rousso
bburg: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch (4.25 KB, patch)
2017-02-25 00:17 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2017-01-15 14:21:13 PST
STEPS TO REPRODUCE:

1. Open inspector
2. Search for something.
3. Select a search result
4. Cmd-C
=> Nothing copied to clipboard

Xcode uses the following format:

`${url}:${lineno}:${resultLine}`

/Users/bburg/repos/webkit/OpenSource/Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:293:# define YYUSE(E) /* empty */


When a resource tree element is selected it multi-selects all results in the resource, which we can't quite do yet with TreeOutline. But copying the resource tree element should probably copy all results underneath it.
Comment 1 Radar WebKit Bug Importer 2017-01-15 14:21:26 PST
<rdar://problem/30033607>
Comment 2 BJ Burg 2017-01-15 14:21:37 PST
It is typical to have a Copy shortcut menu command as well.
Comment 3 Devin Rousso 2017-02-15 18:02:13 PST
Created attachment 301684 [details]
Patch
Comment 4 Matt Baker 2017-02-15 21:40:49 PST
(In reply to comment #3)
> Created attachment 301684 [details]
> Patch

Copying results from minified files can essentially copy the entire file to the clipboard. Is this what we want?
Comment 5 BJ Burg 2017-02-24 21:58:45 PST
Comment on attachment 301684 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2017-02-24 23:52:30 PST
Comment on attachment 301684 [details]
Patch

Rejecting attachment 301684 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 301684, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
w3c/ChangeLog
	M	Source/WebCore/html/HTMLMediaElement.cpp
	M	Source/WebCore/html/HTMLVideoElement.h
	M	Source/WebCore/loader/MediaResourceLoader.cpp
	M	Source/WebCore/loader/MediaResourceLoader.h
	M	Source/WebCore/ChangeLog
	M	Tools/TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm
	M	Tools/ChangeLog
r212994 = cbb24f84557d16b14c9fb853b0e839466e4f26be (refs/remotes/origin/master)
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/3189917
Comment 7 Devin Rousso 2017-02-25 00:17:55 PST
Created attachment 302747 [details]
Patch
Comment 8 WebKit Commit Bot 2017-02-25 00:31:49 PST
Comment on attachment 302747 [details]
Patch

Clearing flags on attachment: 302747

Committed r213000: <http://trac.webkit.org/changeset/213000>
Comment 9 WebKit Commit Bot 2017-02-25 00:31:53 PST
All reviewed patches have been landed.  Closing bug.