Bug 167073 - Web Inspector: Search Tab should display search results immediately when closing and reopening Inspector
Summary: Web Inspector: Search Tab should display search results immediately when clos...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-01-15 14:09 PST by BJ Burg
Modified: 2020-10-27 14:01 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.24 KB, patch)
2017-01-15 21:56 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2017-01-15 14:09:01 PST
STEPS TO REPRODUCE:

1. Inspect a page
2. Search for something
3. Select the third search result
=> Result is revealed in the resource in main content area
4. Close Inspector
5. Reopen Inspector
=> Search Tab and search term is restored, but no results and empty content area
6. Click in search field, press enter
=> Third result is automatically selected and shown in its resource

It appears that we don't perform the search again on restoring the tab. We should do this right away. When results appear the existing state restoration machinery should just do the right thing.
Comment 1 Radar WebKit Bug Importer 2017-01-15 14:09:18 PST
<rdar://problem/30033540>
Comment 2 Devin Rousso 2017-01-15 21:56:38 PST
Created attachment 298938 [details]
Patch
Comment 3 WebKit Commit Bot 2017-01-20 20:52:53 PST
Comment on attachment 298938 [details]
Patch

Clearing flags on attachment: 298938

Committed r211010: <http://trac.webkit.org/changeset/211010>
Comment 4 WebKit Commit Bot 2017-01-20 20:52:56 PST
All reviewed patches have been landed.  Closing bug.