Bug 167063 - De-duplicate more (nearly) identical code in Editor(Mac|IOS).mm
Summary: De-duplicate more (nearly) identical code in Editor(Mac|IOS).mm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-15 00:41 PST by Tim Horton
Modified: 2017-01-15 11:40 PST (History)
7 users (show)

See Also:

Attachments
Patch (20.52 KB, patch)
2017-01-15 00:42 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (20.52 KB, patch)
2017-01-15 00:55 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-elcapitan (407.21 KB, application/zip)
2017-01-15 01:44 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews112 for mac-elcapitan (403.71 KB, application/zip)
2017-01-15 01:49 PST, Build Bot 		no flags Details
Patch (20.56 KB, patch)
2017-01-15 11:03 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2017-01-15 00:41:55 PST 
De-duplicate more (nearly) identical code in Editor(Mac|IOS).mm
Comment 1 Tim Horton 2017-01-15 00:42:45 PST 
Created attachment 298891 [details]
Patch
Comment 2 Tim Horton 2017-01-15 00:55:52 PST 
Created attachment 298894 [details]
Patch
Comment 3 Build Bot 2017-01-15 01:44:45 PST 
Comment on attachment 298894 [details]
Patch

Attachment 298894 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2893223

Number of test failures exceeded the failure limit.
Comment 4 Build Bot 2017-01-15 01:44:48 PST 
Created attachment 298895 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 5 Build Bot 2017-01-15 01:49:28 PST 
Comment on attachment 298894 [details]
Patch

Attachment 298894 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2893228

Number of test failures exceeded the failure limit.
Comment 6 Build Bot 2017-01-15 01:49:31 PST 
Created attachment 298896 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 7 mitz 2017-01-15 09:21:18 PST 
Comment on attachment 298894 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298894&action=review

> Source/WebCore/editing/cocoa/EditorCocoa.mm:107
> +    if (shadow) {

Should null-check shadowData so as not to crash everything (and maybe avoid using “shadow” as a variable name in this code).
Comment 8 Tim Horton 2017-01-15 10:54:08 PST 
(In reply to comment #7)
> Comment on attachment 298894 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=298894&action=review
> 
> > Source/WebCore/editing/cocoa/EditorCocoa.mm:107
> > +    if (shadow) {
> 
> Should null-check shadowData so as not to crash everything (and maybe avoid
> using “shadow” as a variable name in this code).

I... would not have expected that to compile. I will rename and fix :)
Comment 9 Tim Horton 2017-01-15 11:03:40 PST 
Created attachment 298901 [details]
Patch
Comment 10 WebKit Commit Bot 2017-01-15 11:40:47 PST 
Comment on attachment 298901 [details]
Patch

Clearing flags on attachment: 298901

Committed r210779: <http://trac.webkit.org/changeset/210779>
Comment 11 WebKit Commit Bot 2017-01-15 11:40:52 PST 
All reviewed patches have been landed.  Closing bug.