Bug 167063 – De-duplicate more (nearly) identical code in Editor(Mac|IOS).mm

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

De-duplicate more (nearly) identical code in Editor(Mac|IOS).mm

[Tim Horton]

Created attachment 298891 [details]
Patch

[Tim Horton]

Created attachment 298894 [details]
Patch

[Build Bot]

Comment on attachment 298894 [details]
Patch

Attachment 298894 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2893223

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 298895 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298894 [details]
Patch

Attachment 298894 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2893228

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 298896 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment on attachment 298894 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298894&action=review

> Source/WebCore/editing/cocoa/EditorCocoa.mm:107
> +    if (shadow) {

Should null-check shadowData so as not to crash everything (and maybe avoid using “shadow” as a variable name in this code).

[Tim Horton]

(In reply to comment #7)
> Comment on attachment 298894 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=298894&action=review
> 
> > Source/WebCore/editing/cocoa/EditorCocoa.mm:107
> > +    if (shadow) {
> 
> Should null-check shadowData so as not to crash everything (and maybe avoid
> using “shadow” as a variable name in this code).

I... would not have expected that to compile. I will rename and fix :)

[Tim Horton]

Created attachment 298901 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 298901 [details]
Patch

Clearing flags on attachment: 298901

Committed r210779: <http://trac.webkit.org/changeset/210779>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.