Bug 167055 – Remove PassRefPtr from "loader" directory of WebCore

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Darin Adler]

Remove PassRefPtr from "loader" directory of WebCore

[Darin Adler]

Created attachment 298867 [details]
Patch

[WebKit Commit Bot]

Attachment 298867 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:59:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:60:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:61:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:62:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:63:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:64:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 6 in 124 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 298867 [details]
Patch

Attachment 298867 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2890437

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 298869 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298867 [details]
Patch

Attachment 298867 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2890446

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 298870 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298867 [details]
Patch

Attachment 298867 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2890565

New failing tests:
http/tests/appcache/different-origin-manifest.html
http/tests/appcache/cyrillic-uri.html
http/tests/appcache/origin-usage.html
http/tests/appcache/history-test.html
http/tests/appcache/crash-when-navigating-away-then-back.html
http/tests/appcache/simple-video-sync.html
http/tests/appcache/max-size.html
http/tests/appcache/origin-delete.html
http/tests/appcache/top-frame-1.html
http/tests/appcache/whitelist-wildcard.html
http/tests/ssl/verify-ssl-enabled.php
http/tests/appcache/main-resource-fallback-for-network-error-crash.html
http/tests/appcache/origin-quota-continued-download.html
http/tests/appcache/progress-counter.html
http/tests/appcache/reload.html
http/tests/appcache/foreign-iframe-main.html
http/tests/appcache/main-resource-redirect.html
http/tests/appcache/local-content.html
http/tests/appcache/top-frame-3.html
http/tests/appcache/resource-redirect-2.html
http/tests/appcache/wrong-signature-2.html
http/tests/appcache/manifest-parsing.html
http/tests/appcache/update-cache.html
http/tests/appcache/identifier-test.html
http/tests/appcache/offline-access.html
http/tests/security/cross-origin-appcache.html
http/tests/appcache/x-frame-options-prevents-framing.php

[Build Bot]

Created attachment 298871 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Darin Adler]

Created attachment 298885 [details]
Patch

[WebKit Commit Bot]

Attachment 298885 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:59:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:60:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:61:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:62:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:63:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:64:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 6 in 125 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Created attachment 298888 [details]
Patch

[WebKit Commit Bot]

Attachment 298888 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:59:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:60:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:61:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:62:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:63:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:64:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 6 in 129 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Created attachment 298905 [details]
Patch

[WebKit Commit Bot]

Attachment 298905 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:59:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:60:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:61:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:62:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:63:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:64:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 6 in 137 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Darn, still not compiling on iOS. But I am getting closer. Tests all passing, all platforms compiling except for iOS and maybe Windows.

[Darin Adler]

Created attachment 298919 [details]
Patch

[Darin Adler]

Created attachment 298926 [details]
Patch

[WebKit Commit Bot]

Attachment 298926 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:59:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:60:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:61:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:62:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:63:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:64:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 6 in 140 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Created attachment 298930 [details]
Patch

[WebKit Commit Bot]

Attachment 298930 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:59:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:60:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:61:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:62:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:63:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:64:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 6 in 142 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Created attachment 298935 [details]
Patch

[WebKit Commit Bot]

Attachment 298935 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:59:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:60:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:61:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:62:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:63:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:64:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 6 in 143 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

OK, all green now. Review time.

[WebKit Commit Bot]

Comment on attachment 298935 [details]
Patch

Rejecting attachment 298935 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 298935, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
file Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp
patching file Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm
Hunk #1 succeeded at 468 (offset 1 line).
patching file Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm
patching file Source/WebKit2/WebProcess/WebProcess.cpp
patching file Source/WebKit2/WebProcess/WebProcess.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alex Christensen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/2906354

[Darin Adler]

Created attachment 299112 [details]
Patch

[WebKit Commit Bot]

Attachment 299112 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:59:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:60:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:61:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:62:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:63:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:64:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 6 in 141 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 299112 [details]
Patch

Attachment 299112 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2907346

New failing tests:
imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html

[Build Bot]

Created attachment 299116 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Darin Adler]

Committed r210845: <http://trac.webkit.org/changeset/210845>

[Csaba Osztrogonác]

Comment on attachment 299112 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299112&action=review

> Source/WebCore/loader/DocumentLoader.cpp:866
> +        if (m_archive && m_archive->shouldOverrideBaseURL())

This change broke the !ENABLE(MHTML) build, because m_archive 
is declared inside ENABLE(WEB_ARCHIV) || ENABLE(MHTML) guard.

> Source/WebCore/loader/DocumentLoader.cpp:883
> +            if (m_archive && m_archive->shouldUseMainResourceEncoding())

ditto

[Csaba Osztrogonác]

(In reply to comment #29)
> Committed r210845: <http://trac.webkit.org/changeset/210845>

FYI Alex, it broke the WinCairo build:

C:\Users\Alex\Documents\WinCairoBot\win-cairo-release\build\Source\WebKit\win\WebCoreSupport\WebFrameLoaderClient.h(77): error C3668: 'WebFrameLoaderClient::shouldCacheResponse': method with override specifier 'override' did not override any base class methods

C:\Users\Alex\Documents\WinCairoBot\win-cairo-release\build\Source\WebKit\win\WebCoreSupport\WebFrameLoaderClient.h(77): error C3668: 'WebFrameLoaderClient::shouldCacheResponse': method with override specifier 'override' did not override any base class methods

C:\Users\Alex\Documents\WinCairoBot\win-cairo-release\build\Source\WebKit\win\WebCoreSupport\WebFrameLoaderClient.h(77): error C3668: 'WebFrameLoaderClient::shouldCacheResponse': method with override specifier 'override' did not override any base class methods

C:\Users\Alex\Documents\WinCairoBot\win-cairo-release\build\Source\WebKit\win\WebCoreSupport\WebFrameLoaderClient.h(77): error C3668: 'WebFrameLoaderClient::shouldCacheResponse': method with override specifier 'override' did not override any base class methods

C:\Users\Alex\Documents\WinCairoBot\win-cairo-release\build\Source\WebKit\win\WebCoreSupport\WebFrameLoaderClient.h(77): error C3668: 'WebFrameLoaderClient::shouldCacheResponse': method with override specifier 'override' did not override any base class methods
ninja: build stopped: subcommand failed.

[Alex Christensen]

https://trac.webkit.org/changeset/210863