Bug 167049 – WebAssembly: Suppress warnings & errors in GCC

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

WebAssembly: Suppress warnings & errors in GCC

[Yusuke Suzuki]

Created attachment 298855 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 298855 [details]
Patch

Thanks :)

[WebKit Commit Bot]

Comment on attachment 298855 [details]
Patch

Clearing flags on attachment: 298855

Committed r210769: <http://trac.webkit.org/changeset/210769>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 298855 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298855&action=review

> Source/JavaScriptCore/ChangeLog:12
> +        Add missing { } after the switch. Ideally, it is not necessary.
> +        But in GCC, it is required. Since this function is fairly large,
> +        I think the code generated by this does not cause performance
> +        regression.

This has been coming up a *lot* for me. I suspect this is about older versions of GCC, since we see it on the EFL bot and not the GTK bot, but I suppose we need to support those older versions.

[Darin Adler]

Comment on attachment 298855 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298855&action=review

> Source/JavaScriptCore/wasm/generateWasmValidateInlinesHeader.py:130
> +#if COMPILER(GCC) && ASSERT_DISABLED

It bothers me a little that this says COMPILER(GCC) if I am correct and the false positive warning does not occurs with newer versions of GCC.

[Yusuke Suzuki]

Comment on attachment 298855 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298855&action=review

>> Source/JavaScriptCore/ChangeLog:12
>> +        regression.
> 
> This has been coming up a *lot* for me. I suspect this is about older versions of GCC, since we see it on the EFL bot and not the GTK bot, but I suppose we need to support those older versions.

I'm not 100% confident, but I guess this is due to the GCC version.
But it is rather caused in the newer GCC I guess.

At least, I tested it on GCC 6.3.1 on Fedora 25. It is quite new: 6.3 is released at December 21, 2016.

>> Source/JavaScriptCore/wasm/generateWasmValidateInlinesHeader.py:130
>> +#if COMPILER(GCC) && ASSERT_DISABLED
> 
> It bothers me a little that this says COMPILER(GCC) if I am correct and the false positive warning does not occurs with newer versions of GCC.

This warning is caused in the GCC at least version 6.3.1.
So I think this macro is not meaningless on the very new GCC.