WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
167039
[WebIDL] Remove custom bindings for HTMLInputElement, HTMLFrameElement, HTMLMediaElement and HTMLOptionsCollection
https://bugs.webkit.org/show_bug.cgi?id=167039
Summary
[WebIDL] Remove custom bindings for HTMLInputElement, HTMLFrameElement, HTMLM...
Sam Weinig
Reported
2017-01-13 17:22:50 PST
[WebIDL] Remove custom bindings for HTMLInputElement, HTMLFrameElement, HTMLMediaElement and HTMLOptionsCollection
Attachments
Patch
(35.50 KB, patch)
2017-01-13 17:29 PST
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews115 for mac-elcapitan
(1.19 MB, application/zip)
2017-01-13 18:05 PST
,
Build Bot
no flags
Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2
(520.91 KB, application/zip)
2017-01-13 18:07 PST
,
Build Bot
no flags
Details
Archive of layout-test-results from ews101 for mac-elcapitan
(592.59 KB, application/zip)
2017-01-13 18:10 PST
,
Build Bot
no flags
Details
Archive of layout-test-results from ews125 for ios-simulator-wk2
(
deleted
)
2017-01-13 18:29 PST
,
Build Bot
no flags
Details
Patch
(35.50 KB, patch)
2017-01-13 18:39 PST
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews100 for mac-elcapitan
(914.53 KB, application/zip)
2017-01-13 19:42 PST
,
Build Bot
no flags
Details
Archive of layout-test-results from ews107 for mac-elcapitan-wk2
(959.09 KB, application/zip)
2017-01-13 19:45 PST
,
Build Bot
no flags
Details
Archive of layout-test-results from ews116 for mac-elcapitan
(1.64 MB, application/zip)
2017-01-13 19:53 PST
,
Build Bot
no flags
Details
Archive of layout-test-results from ews123 for ios-simulator-wk2
(9.13 MB, application/zip)
2017-01-13 19:56 PST
,
Build Bot
no flags
Details
Patch
(41.15 KB, patch)
2017-01-14 10:39 PST
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Patch
(41.81 KB, patch)
2017-01-14 11:40 PST
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Show Obsolete
(11)
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2017-01-13 17:29:03 PST
Created
attachment 298815
[details]
Patch
Build Bot
Comment 2
2017-01-13 18:05:05 PST
Comment on
attachment 298815
[details]
Patch
Attachment 298815
[details]
did not pass mac-debug-ews (mac): Output:
http://webkit-queues.webkit.org/results/2885302
Number of test failures exceeded the failure limit.
Build Bot
Comment 3
2017-01-13 18:05:07 PST
Created
attachment 298820
[details]
Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 4
2017-01-13 18:06:58 PST
Comment on
attachment 298815
[details]
Patch
Attachment 298815
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.webkit.org/results/2885326
Number of test failures exceeded the failure limit.
Build Bot
Comment 5
2017-01-13 18:07:00 PST
Created
attachment 298821
[details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Build Bot
Comment 6
2017-01-13 18:10:24 PST
Comment on
attachment 298815
[details]
Patch
Attachment 298815
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.webkit.org/results/2885336
Number of test failures exceeded the failure limit.
Build Bot
Comment 7
2017-01-13 18:10:26 PST
Created
attachment 298822
[details]
Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 8
2017-01-13 18:29:14 PST
Comment on
attachment 298815
[details]
Patch
Attachment 298815
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
http://webkit-queues.webkit.org/results/2885354
Number of test failures exceeded the failure limit.
Build Bot
Comment 9
2017-01-13 18:29:19 PST
Created
attachment 298824
[details]
Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Sam Weinig
Comment 10
2017-01-13 18:39:42 PST
Created
attachment 298826
[details]
Patch
Build Bot
Comment 11
2017-01-13 19:41:57 PST
Comment on
attachment 298826
[details]
Patch
Attachment 298826
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.webkit.org/results/2885661
New failing tests: fast/dom/HTMLSelectElement/select-selectedIndex.html inspector/model/remote-object-get-properties.html fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html fast/forms/selection-functions.html fast/forms/selection-wrongtype.html
Build Bot
Comment 12
2017-01-13 19:42:00 PST
Created
attachment 298836
[details]
Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 13
2017-01-13 19:44:57 PST
Comment on
attachment 298826
[details]
Patch
Attachment 298826
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.webkit.org/results/2885662
New failing tests: fast/dom/HTMLSelectElement/select-selectedIndex.html inspector/model/remote-object-get-properties.html fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html fast/forms/selection-functions.html fast/forms/selection-wrongtype.html
Build Bot
Comment 14
2017-01-13 19:45:00 PST
Created
attachment 298837
[details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Build Bot
Comment 15
2017-01-13 19:53:44 PST
Comment on
attachment 298826
[details]
Patch
Attachment 298826
[details]
did not pass mac-debug-ews (mac): Output:
http://webkit-queues.webkit.org/results/2885676
New failing tests: fast/dom/HTMLSelectElement/select-selectedIndex.html inspector/model/remote-object-get-properties.html fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html fast/forms/selection-functions.html fast/forms/selection-wrongtype.html
Build Bot
Comment 16
2017-01-13 19:53:46 PST
Created
attachment 298839
[details]
Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 17
2017-01-13 19:56:04 PST
Comment on
attachment 298826
[details]
Patch
Attachment 298826
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
http://webkit-queues.webkit.org/results/2885665
New failing tests: fast/dom/HTMLSelectElement/select-selectedIndex.html fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html fast/forms/selection-functions.html fast/forms/selection-wrongtype.html
Build Bot
Comment 18
2017-01-13 19:56:07 PST
Created
attachment 298840
[details]
Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Sam Weinig
Comment 19
2017-01-14 10:39:23 PST
Created
attachment 298856
[details]
Patch
Sam Weinig
Comment 20
2017-01-14 11:40:15 PST
Created
attachment 298857
[details]
Patch
Sam Weinig
Comment 21
2017-01-14 15:55:04 PST
Ready for review.
Darin Adler
Comment 22
2017-01-14 21:46:24 PST
Comment on
attachment 298857
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=298857&action=review
> Source/WebCore/html/HTMLSelectElement.cpp:466 > + document().addConsoleMessage(MessageSource::Other, MessageLevel::Warning, String::format("Blocked attempt to expand the option list to %u items. The maximum number of items allowed is %u.", newLength, maxSelectItems));
We need that makeString thing so we don’t use String::format.
WebKit Commit Bot
Comment 23
2017-01-15 12:06:29 PST
Comment on
attachment 298857
[details]
Patch Clearing flags on attachment: 298857 Committed
r210780
: <
http://trac.webkit.org/changeset/210780
>
WebKit Commit Bot
Comment 24
2017-01-15 12:06:35 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug