Bug 167036 - Correct potential nullptr dereference in RenderLayer::updateLayerPosition()
Summary: Correct potential nullptr dereference in RenderLayer::updateLayerPosition()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-01-13 17:00 PST by Brent Fulgham
Modified: 2017-01-13 19:43 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.51 KB, patch)
2017-01-13 17:04 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2017-01-13 17:00:58 PST 
Crash logs indicate an infrequent crash in RenderLayer::updateLayerPosition().

Code inspection reveals that we might dereference a nullptr for elements with enclosing parents with a layer. The search for this parent might end without finding anything, resulting in the ancestor being set to nullptr.

This patch adds the missing nullptr check to avoid this possibility.
Comment 1 Brent Fulgham 2017-01-13 17:01:18 PST 
<rdar://problem/30023019>
Comment 2 Brent Fulgham 2017-01-13 17:04:16 PST 
Created attachment 298810 [details]
Patch
Comment 3 Dean Jackson 2017-01-13 18:45:27 PST 
Comment on attachment 298810 [details]
Patch

Test case?
Comment 4 WebKit Commit Bot 2017-01-13 19:43:38 PST 
Comment on attachment 298810 [details]
Patch

Clearing flags on attachment: 298810

Committed r210760: <http://trac.webkit.org/changeset/210760>
Comment 5 WebKit Commit Bot 2017-01-13 19:43:41 PST 
All reviewed patches have been landed.  Closing bug.