Bug 167006 – [WebIDL] Remove custom bindings for DeviceMotionEvent and DeviceOrientationEvent

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

[WebIDL] Remove custom bindings for DeviceMotionEvent and DeviceOrientationEvent

[Sam Weinig]

Created attachment 298761 [details]
Patch

[Alex Christensen]

Comment on attachment 298761 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298761&action=review

> Source/WebCore/dom/DeviceMotionData.h:47
> +        std::optional<double> x() const { return m_x; }

Can these return std::optional<double>&?

> Source/WebCore/dom/DeviceOrientationEvent.idl:36
> +    [ImplementedAs=compassHeading] readonly attribute unrestricted double? webkitCompassHeading;

Do we want to add unprefixed versions?

[Sam Weinig]

Created attachment 298765 [details]
Patch

[Sam Weinig]

(In reply to comment #2)
> Comment on attachment 298761 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=298761&action=review
> 
> > Source/WebCore/dom/DeviceMotionData.h:47
> > +        std::optional<double> x() const { return m_x; }
> 
> Can these return std::optional<double>&?

I'm not sure it's worth it. The copy is really cheap. 

> 
> > Source/WebCore/dom/DeviceOrientationEvent.idl:36
> > +    [ImplementedAs=compassHeading] readonly attribute unrestricted double? webkitCompassHeading;
> 
> Do we want to add unprefixed versions?

(In reply to comment #2)
> Comment on attachment 298761 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=298761&action=review
> 
> > Source/WebCore/dom/DeviceMotionData.h:47
> > +        std::optional<double> x() const { return m_x; }
> 
> Can these return std::optional<double>&?
> 
> > Source/WebCore/dom/DeviceOrientationEvent.idl:36
> > +    [ImplementedAs=compassHeading] readonly attribute unrestricted double? webkitCompassHeading;
> 
> Do we want to add unprefixed versions?

No idea.

[Build Bot]

Comment on attachment 298765 [details]
Patch

Attachment 298765 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2883591

New failing tests:
fast/dom/DeviceMotion/optional-event-properties.html

[Build Bot]

Created attachment 298773 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Sam Weinig]

Created attachment 298778 [details]
Patch

[Geoffrey Garen]

Comment on attachment 298778 [details]
Patch

r=me

[Build Bot]

Comment on attachment 298778 [details]
Patch

Attachment 298778 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2883966

New failing tests:
fast/dom/DeviceMotion/optional-event-properties.html

[Build Bot]

Created attachment 298783 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Sam Weinig]

Committed r210741: <http://trac.webkit.org/changeset/210741>