Bug 167005 - Added preprocessor guard for iOS-specific piece of code in GraphicsContext3DOpenGL
Summary: Added preprocessor guard for iOS-specific piece of code in GraphicsContext3DO...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Konstantin Tokarev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-13 07:52 PST by Konstantin Tokarev
Modified: 2017-01-13 09:32 PST (History)
7 users (show)

See Also:


Attachments
Patch (1.80 KB, patch)
2017-01-13 07:53 PST, Konstantin Tokarev
achristensen: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2017-01-13 07:52:09 PST
Variable boundFrameBuffer is used only in IOS-specific code
Comment 1 Konstantin Tokarev 2017-01-13 07:53:46 PST
Created attachment 298759 [details]
Patch
Comment 2 Konstantin Tokarev 2017-01-13 09:03:08 PST
Comment on attachment 298759 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298759&action=review

> Source/WebCore/ChangeLog:8
> +        Variable "boundFrameBuffer" is used only in IOS-specific code

Oops, will change to iOS before commiting
Comment 3 Konstantin Tokarev 2017-01-13 09:24:37 PST
Committed r210731: <http://trac.webkit.org/changeset/210731>
Comment 4 Daniel Bates 2017-01-13 09:26:42 PST
Comment on attachment 298759 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298759&action=review

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:232
>      GLint boundFrameBuffer;
>      ::glGetIntegerv(GL_FRAMEBUFFER_BINDING, &boundFrameBuffer);

Can we move this code into the existing PLATFORM(IOS)-guarded section below or do we need to execute this statement before the glBindFramebufferEXT() calls? Obviously, the benefit of moving this code under the existing PLATFORM(IOS)-guarded code section in this functions is that we can avoid adding another guard.
Comment 5 Alex Christensen 2017-01-13 09:29:39 PST
We definitely need to check which frame buffer is bound before binding another one.
Comment 6 Daniel Bates 2017-01-13 09:32:27 PST
(In reply to comment #5)
> We definitely need to check which frame buffer is bound before binding
> another one.

I'm blind.