RESOLVED FIXED 167005
Added preprocessor guard for iOS-specific piece of code in GraphicsContext3DOpenGL 
https://bugs.webkit.org/show_bug.cgi?id=167005
Summary Added preprocessor guard for iOS-specific piece of code in GraphicsContext3DO...
Konstantin Tokarev
Reported 2017-01-13 07:52:09 PST
Variable boundFrameBuffer is used only in IOS-specific code
Attachments
Patch (1.80 KB, patch)
2017-01-13 07:53 PST, Konstantin Tokarev 		achristensen: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2017-01-13 07:53:46 PST
Created attachment 298759 [details] Patch
Konstantin Tokarev
Comment 2 2017-01-13 09:03:08 PST
Comment on attachment 298759 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298759&action=review > Source/WebCore/ChangeLog:8 > + Variable "boundFrameBuffer" is used only in IOS-specific code Oops, will change to iOS before commiting
Konstantin Tokarev
Comment 3 2017-01-13 09:24:37 PST
Committed r210731: <http://trac.webkit.org/changeset/210731>
Daniel Bates
Comment 4 2017-01-13 09:26:42 PST
Comment on attachment 298759 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298759&action=review > Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:232 > GLint boundFrameBuffer; > ::glGetIntegerv(GL_FRAMEBUFFER_BINDING, &boundFrameBuffer); Can we move this code into the existing PLATFORM(IOS)-guarded section below or do we need to execute this statement before the glBindFramebufferEXT() calls? Obviously, the benefit of moving this code under the existing PLATFORM(IOS)-guarded code section in this functions is that we can avoid adding another guard.
Alex Christensen
Comment 5 2017-01-13 09:29:39 PST
We definitely need to check which frame buffer is bound before binding another one.
Daniel Bates
Comment 6 2017-01-13 09:32:27 PST
(In reply to comment #5) > We definitely need to check which frame buffer is bound before binding > another one. I'm blind.
Note You need to log in before you can comment on or make changes to this bug.